0xGoodess - FootiumEscrow uses approve which may fail for non standard ERC20

[sherlock-admin]

0xGoodess

medium

FootiumEscrow uses approve which may fail for non standard ERC20

Summary

FootiumEscrow uses approve which may fail for non standard ERC20

Vulnerability Detail

    function setApprovalForERC20(
        IERC20 erc20Contract,
        address to,
        uint256 amount
    ) external onlyClubOwner {
        erc20Contract.approve(to, amount); @>audit
    }

Impact

FootiumEscrow uses approve which may fail for non standard ERC20

Code Snippet

https://github.com/sherlock-audit/2023-04-footium/blob/main/footium-eth-shareable/contracts/FootiumEscrow.sol#L75-L81

Tool used

Manual Review

Recommendation

    function setApprovalForERC20(
        IERC20 erc20Contract,
        address to,
        uint256 amount
    ) external onlyClubOwner {
        erc20Contract.safeApprove(to, amount); @>audit
    }

Duplicate of #14