mstpr-brainbot - transfer can fail for non standard ERC20 tokens

[sherlock-admin]

mstpr-brainbot

high

transfer can fail for non standard ERC20 tokens

Summary

Some tokens does not have return values as booleans which would fail if its used with IERC20(address).transfer. To mitigate this safeTransfer should be used.

Vulnerability Detail

As stated in summary, due to some Non standard ERC20-s not returning boolean in transfers, it is best to use safeTransfer instead of transfer. In case of these tokens (i.e: USDT) received by the contract, tokens will be stucked forever since transfer will not go through

Impact

Code Snippet

https://github.com/sherlock-audit/2023-04-footium/blob/main/footium-eth-shareable/contracts/FootiumEscrow.sol#L110
https://github.com/sherlock-audit/2023-04-footium/blob/main/footium-eth-shareable/contracts/FootiumPrizeDistributor.sol#L130

Tool used

Manual Review

Recommendation

Use safeTransfer instead of transfer

Duplicate of #14