Skip to content

Latest commit

 

History

History
45 lines (24 loc) · 1.08 KB

083.md

File metadata and controls

45 lines (24 loc) · 1.08 KB

Prehistoric Cobalt Aphid

Medium

Tokens may not have decimals or symbol and it will be impossible to create lending pools for them

Summary

$MKR does not present these interfaces, so it will not work for it even though it is EIP20 compliant.

name OPTIONAL - This method can be used to improve usability, but interfaces and other contracts MUST NOT expect these values to be present.

symbol This method can be used to improve usability, but interfaces and other contracts MUST NOT expect these values to be present.

But the LendingPool always calls these in the constructor.

Root Cause

In LendingPool:53/54, name and symbol interface may not exist.

Internal Pre-conditions

None.

External Pre-conditions

None.

Attack Path

  1. Lending pool constructor.

Impact

Lending pool creation fails for certain tokens.

PoC

See $MKR token.

Mitigation

Add the option to pass as argument name and symbol.