Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return schema specification to manifest #2207

Open
1 task done
ppfeister opened this issue Jun 29, 2024 · 1 comment · May be fixed by #2212
Open
1 task done

Return schema specification to manifest #2207

ppfeister opened this issue Jun 29, 2024 · 1 comment · May be fixed by #2212
Assignees
@ppfeister
Labels
enhancement New feature or request

Comments

@ppfeister
Copy link
Member

Description

The schema specification was removed from the manifest after first being added, as the new key type was breaking some outdated clients.

I believe enough time has passed for us to add this back. Most users should be up to date by now, unless they've been ignoring an update notification for this long.

Either @sdushantha or @matheusfelipeog oppose?

Code of Conduct

  • I agree to follow this project's Code of Conduct
@ppfeister ppfeister added the enhancement New feature or request label Jun 29, 2024
@matheusfelipeog
Copy link
Collaborator

I agree. I think we can do this already.

@ppfeister ppfeister linked a pull request Jul 1, 2024 that will close this issue
Open
@ppfeister ppfeister self-assigned this Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ppfeister ppfeister

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return schema to manifest sherlock-project/sherlock
2 participants
@ppfeister @matheusfelipeog