Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for release into maven repository #16

Open
cmeng-git opened this issue Aug 24, 2020 · 7 comments
Open

Request for release into maven repository #16

cmeng-git opened this issue Aug 24, 2020 · 7 comments
Assignees

Comments

@cmeng-git
Copy link

Appreciate if you can consider release your jarjar libraries into the official maven repository, so aTalk can refer to it.
aTalk release the apk into android playstore and Fdroid. Fdroid has restriction on inclusion of any pre-built jar into the source.

aTalk is an open source: https://github.com/cmeng-git/atalk-android

Currently aTalk build.gradle is making reference to 'org.anarres.jarjar' jarjar, but seems this tool has not been updated for a while and is facing some problem i.e. NullPointerException in LambdaClass.createLambdaImplMethodTarget

=================
buildscript {
repositories {
google()
jcenter()
}

dependencies {
    classpath 'org.anarres.jarjar:jarjar-gradle:1.0.1' // working jarjar.repackage version
}

}

apply plugin: 'org.anarres.jarjar'

@liutikas
Copy link

@shevek we'd also love to get a new release of your plugin. We need to pick up ASM8 support upgrade

Please release 1.0.2 from current master.

@shevek shevek self-assigned this Jan 26, 2021
@hannesa2
Copy link

hannesa2 commented Apr 7, 2021

I hope this will help you #20 but there is current no publish included

@cmeng-git
Copy link
Author

Thanks for the new input. Would you be able to provide an example on how to use the jarjar 1.0.3 in gradle.

When I change the aTalk build.gradle to
buildscript {
repositories {
google()
mavenCentral()
}

dependencies {
    classpath "org.anarres.jarjar:jarjar-gradle:1.0.3"
}

}

Gradle sync immediately exit with the following errors:

A problem occurred configuring project ':buildSrc'.

Could not resolve all artifacts for configuration ':buildSrc:classpath'.
Could not find org.anarres.jarjar:jarjar-gradle:1.0.3.
Searched in the following locations:
- https://dl.google.com/dl/android/maven2/org/anarres/jarjar/jarjar-gradle/1.0.3/jarjar-gradle-1.0.3.pom
- https://repo.maven.apache.org/maven2/org/anarres/jarjar/jarjar-gradle/1.0.3/jarjar-gradle-1.0.3.pom
- https://plugins.gradle.org/m2/org/anarres/jarjar/jarjar-gradle/1.0.3/jarjar-gradle-1.0.3.pom
Required by:
project :buildSrc

===============
For jarjar v1.0.1 it was released in the maven repository, hence there is no problem when v1.0.1 is used.
https://mvnrepository.com/artifact/org.anarres.jarjar/jarjar-gradle

I also made refer to the following file, but none help.
https://github.com/shevek/jarjar/blob/master/jarjar-gradle/example/build.gradle

@ungesehn
Copy link

@shevek Any chance to have an update released soon? Especially in the light of #22

@reisi007
Copy link

Should we try to publish this repo from a fork under a different maven coordinate?

@liutikas
Copy link

I suggest moving to https://github.com/johnrengelman/shadow

That's what we ended up doing on my team.

@cmeng-git
Copy link
Author

I tried on aTalk project but facing problem. Any advice will be appreciated.

Unable to use shadow to achieve the same result as jarjar tools for aTalk project #761

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants