Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local Policy #19

Open
mutexl0ck opened this issue Mar 13, 2017 · 0 comments
Open

Local Policy #19

mutexl0ck opened this issue Mar 13, 2017 · 0 comments

Comments

@mutexl0ck
Copy link

While attempting to setup a local policy on my production Postfix server to allow improperly used mailing list messages to come through, I could not get a local policy working. After troubleshooting with the spfquery tool and looking at the code I realized the local policy would never work because spf_request->use_local_policy is never set.

spf_interprect.c performs a check against spf_request->use_local_policy on line 671. It looks like use_local_policy is never used outside of this not null check.

if ( spf_request->use_local_policy ) {

Should it be up to the calling code (Postfix, etc) to set this? If so, shouldn't spfquery set it when the -local option is used on the command line?

My fix for my environment was to simply remove the conditional on line 671 in spf_interprect.c. After doing so, both the spfquery tool and Postfix began working as expected using the local policy I defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant