Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite doesn't work #46

Open
nomis opened this issue Oct 2, 2023 · 1 comment
Open

Test suite doesn't work #46

nomis opened this issue Oct 2, 2023 · 1 comment

Comments

@nomis
Copy link
Contributor

nomis commented Oct 2, 2023

The required -dns=test option was removed from spfquery in 2008, so it just does this:

$ ./run_all

Running piped tests using live data...
Running tests from test_live.txt (with args '-pipe --todo=121=FIXME --todo=135.result=FIXME --todo=136.result=FIXME --todo=137.result=FIXME --todo=139=Persistent_data_error? --todo=140=Persistent_data_error? --todo=142=Persistent_data_error? --todo=145=Persistent_data_error? --todo=146=Persistent_data_error? --todo=149=Persistent_data_error? --todo=154=Persistent_data_error? --todo=155=Persistent_data_error? --todo=156=Persistent_data_error? --todo=157=Persistent_data_error? --todo=158=Persistent_data_error? --todo=159=Persistent_data_error? --todo=160=Persistent_data_error? --todo=161=Persistent_data_error? --todo=162=Persistent_data_error? --todo=163=Persistent_data_error? --todo=164=Persistent_data_error? --todo=165=Persistent_data_error? --todo=166=Persistent_data_error? --todo=167=Persistent_data_error? --todo=168=FIXME --todo=169=FIXME')...
Error:  635 tests failed

Running piped tests using static test dns zone file...

Running single tests using live data...
Running tests from test_live.txt (with args '--todo=121=FIXME --todo=135.result=FIXME --todo=136.result=FIXME --todo=137.result=FIXME --todo=168=FIXME --todo=169=FIXME')...
Error:  765 tests failed

Running single tests using adoption roll data...
Running tests from test_adopt_roll.txt (with args '')...
Error:  100 tests failed

Running single tests using live data...
Running tests from test_live.txt (with args '--todo=121=FIXME --todo=135.result=FIXME --todo=136.result=FIXME --todo=137.result=FIXME --todo=168=FIXME --todo=169=FIXME')...
Error:  765 tests failed

Running single tests on the parser...
Running tests from test_parser.txt (with args '')...
All regression tests passed

Running single tests using data from the RFC examples...
Running tests from test_rfc_examples.txt (with args '')...
Error:  46 tests failed

Running single tests using static test dns zone file...

Running piped tests using live data...
Running tests from test_live.txt (with args '-pipe -test-opt=-dns=test --todo=121=FIXME --todo=135.result=FIXME --todo=136.result=FIXME --todo=137.result=FIXME --todo=139=Persistent_data_error? --todo=140=Persistent_data_error? --todo=142=Persistent_data_error? --todo=145=Persistent_data_error? --todo=146=Persistent_data_error? --todo=149=Persistent_data_error? --todo=154=Persistent_data_error? --todo=155=Persistent_data_error? --todo=156=Persistent_data_error? --todo=157=Persistent_data_error? --todo=158=Persistent_data_error? --todo=159=Persistent_data_error? --todo=160=Persistent_data_error? --todo=161=Persistent_data_error? --todo=162=Persistent_data_error? --todo=163=Persistent_data_error? --todo=164=Persistent_data_error? --todo=165=Persistent_data_error? --todo=166=Persistent_data_error? --todo=167=Persistent_data_error? --todo=168=FIXME --todo=169=FIXME')...
Error:  635 tests failed
@nomis
Copy link
Contributor Author

nomis commented Oct 2, 2023

Ideally this library would be rewritten in C++ to avoid all the complicated custom memory management but the test suite needs to work first to ensure nothing is broken.

(It can still provide the same C API to be backwards-compatible.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant