Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow API calls to be made without .php in the path #735

Open
carrythebanner opened this issue Jun 11, 2024 · 0 comments
Open

Allow API calls to be made without .php in the path #735

carrythebanner opened this issue Jun 11, 2024 · 0 comments

Comments

@carrythebanner
Copy link
Collaborator

For backwards compatibility while transitioning the backend from PHP to Node, we intentionally maintained .php in API paths even though they were no longer PHP files, e.g. https://localhost:4443/api/events.php?startdate=2019-06-01&enddate=2019-06-15

(See implementation in https://github.com/shift-org/shift-docs/blob/main/app/app.js#L52)

We should drop .php from the canonical URLs, e.g. https://localhost:4443/api/events?startdate=2019-06-01&enddate=2019-06-15

For backwards compatibility we should proxy/redirect the .php paths to the new canonical path, but encourage clients to update their API calls to the new path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant