Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The default config file is not cacheable #55

Open
j3j5 opened this issue Mar 4, 2020 · 2 comments
Open

The default config file is not cacheable #55

j3j5 opened this issue Mar 4, 2020 · 2 comments

Comments

@j3j5
Copy link

j3j5 commented Mar 4, 2020

Trying to run php artisan config:cache on a project with this package installed fails because commit 10c3a1f introduced a not serializable value on the config file. The logger is now created on the config file instead of on the Service Provider.

Unless you have a very good reason for this, I can make a PR moving that code back to the service provider and restoring the logPath and logLevel on the config file. I guess I could make it backwards compatible that only if you don't have the logger on the config file it gets created on the service provider.

Let me know what you think.

@candasm
Copy link
Collaborator

candasm commented Mar 5, 2020

Hello @j3j5 ,

Can you please share with me the version you use and also the version of laravel/lumen framework?

@j3j5
Copy link
Author

j3j5 commented Mar 5, 2020

Hi @candasm, I'm using Laravel 6 and laravel-elasticsearch 4.5.1 although the issue will surface on Laravel 5 as well, since afaik the call to create the default logger from the builder class won't be serializable anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants