Skip to content

Commit aace0fa

Browse files
committed
refactor(eslint-config): new rules and auto fix own code
1 parent 17a05a0 commit aace0fa

File tree

20 files changed

+46
-30
lines changed

20 files changed

+46
-30
lines changed

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
"@commitlint/cli": "^19.3.0",
2727
"@commitlint/config-angular": "^19.3.0",
2828
"@commitlint/prompt-cli": "^19.3.1",
29+
"@jest/globals": "^29.5.0",
2930
"@types/jest": "^29.5.12",
3031
"@types/node": "^22.15.0",
3132
"eslint": "^9.36.0",

packages/eslint-config-recommended/src/angular/index.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
import eslintAngular from 'angular-eslint'
2-
import { defineScTsConfig } from '../index.js'
32
import { defineConfig } from 'eslint/config'
43

4+
import { defineScTsConfig } from '../index.js'
5+
56
/**
67
* define the shiftcode eslint config for angular.
78
* the function wraps given configs with some common settings and rules and adds prettier rules at the end.

packages/eslint-config-recommended/src/index.ts

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import eslint from '@eslint/js'
2+
import eslintScPlugin from '@shiftcode/eslint-plugin-rules'
3+
import { defineConfig } from 'eslint/config'
24
import eslintPrettier from 'eslint-config-prettier'
35
import eslintPluginImport from 'eslint-plugin-import'
6+
import eslintPluginSimpleImportSort from 'eslint-plugin-simple-import-sort'
47
import eslintPluginUnusedImports from 'eslint-plugin-unused-imports'
5-
import eslintScPlugin from '@shiftcode/eslint-plugin-rules'
68
import eslintTs from 'typescript-eslint'
79

8-
import { defineConfig } from 'eslint/config'
9-
1010
/**
1111
* define the shiftcode eslint config for typescript.
1212
* the function wraps given configs with some common settings and adds prettier rules at the end.
@@ -36,7 +36,12 @@ export function defineScTsConfig(...configs: Parameters<typeof defineConfig>): R
3636
{
3737
files: ['**/*.{ts,mts,cts,js,mjs,cjs}'],
3838
extends: [eslint.configs.recommended],
39+
plugins: {
40+
'simple-import-sort': eslintPluginSimpleImportSort,
41+
},
3942
rules: {
43+
'simple-import-sort/imports': 'error',
44+
'simple-import-sort/exports': 'error',
4045
'no-console': 'error',
4146
'max-classes-per-file': 'error',
4247
curly: 'error',

packages/eslint-plugin-rules/src/index.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1+
import { ConfigObject, Plugin, RuleDefinition } from '@eslint/core'
2+
13
import { denyParentIndexFileImportRule } from './rules/deny-parent-index-file-import.js'
24
import { importDenyListRule } from './rules/import-denylist.js'
35
import { prefixBuiltinModuleImportRule } from './rules/prefix-builtin-module-import.js'
4-
import { ConfigObject, Plugin, RuleDefinition } from '@eslint/core'
56

67
const DEFAULT_RULE_NS = `@shiftcode`
78

packages/eslint-plugin-rules/src/rules/deny-parent-index-file-import.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
// ------------------------------------------------------------------------------
44
import { TSESTree } from '@typescript-eslint/utils'
55
import { RuleContext } from '@typescript-eslint/utils/ts-eslint'
6+
67
import { createScRule } from './create-rule.function.js'
78

89
export enum DenyParentIndexFileImportMessageIds {

packages/eslint-plugin-rules/src/rules/import-denylist.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
// Rule Definition
33
// ------------------------------------------------------------------------------
44
import { RuleContext } from '@typescript-eslint/utils/ts-eslint'
5+
56
import { createScRule } from './create-rule.function.js'
67

78
export enum ImportDenylistMessageIds {

packages/eslint-plugin-rules/src/rules/prefix-builtin-module-import.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
1+
import { builtinModules } from 'node:module'
2+
13
import { TSESTree } from '@typescript-eslint/utils'
24
import { RuleContext } from '@typescript-eslint/utils/ts-eslint'
3-
import { builtinModules } from 'node:module'
5+
46
import { createScRule } from './create-rule.function.js'
57
// ------------------------------------------------------------------------------
68
// Rule Definition

packages/eslint-plugin-rules/src/utils/rule-tester.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
1-
import { RuleTester } from '@typescript-eslint/rule-tester'
21
import { join } from 'node:path'
2+
33
import * as parser from '@typescript-eslint/parser'
4+
import { RuleTester } from '@typescript-eslint/rule-tester'
45

56
const tsRootDirectory = join(__dirname, '../..', 'test')
67

packages/logger/src/index.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
1-
export * from './model/logger.js'
1+
export * from './model/json-log-object-data.js'
2+
export * from './model/json-log-transport.js'
23
export * from './model/log-level.enum.js'
34
export * from './model/log-transport.js'
4-
export * from './model/json-log-transport.js'
5-
export * from './model/json-log-object-data.js'
6-
5+
export * from './model/logger.js'
76
export * from './services/base-logger.service.js'
8-
97
export * from './utils/logger-helper.js'

packages/logger/src/model/json-log-object-data.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { getEnumKeyFromNum } from '@shiftcode/utilities'
2+
23
import { LogLevel } from './log-level.enum.js'
34

45
export interface JsonLogObjectData {

0 commit comments

Comments
 (0)