Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade yard to version 0.9.11 or later #169

Open
emma5678 opened this issue Feb 12, 2019 · 5 comments
Open

Upgrade yard to version 0.9.11 or later #169

emma5678 opened this issue Feb 12, 2019 · 5 comments

Comments

@emma5678
Copy link

emma5678 commented Feb 12, 2019

Yard vulnerability has been present in flex-commerce-api.gemspec since Dec 2017. We need to upgrade to 0.9.11 or later.

Issue also present in penthouse repo: shiftcommerce/penthouse#13

This needs to be complete by April 2019.

Due to time passed, I would suggest updating to the very latest version, if greater than 0.9.11, unless an issue is identified with doing so.

Vulnerability details:

lib/yard/core_ext/file.rb in the server in YARD before 0.9.11 does not block relative paths with an initial ../ sequence, which allows attackers to conduct directory traversal attacks and read arbitrary files.

@emma5678
Copy link
Author

@krisquigley @ryantownsend can this be addressed please.

@emma5678
Copy link
Author

emma5678 commented Sep 9, 2019

@ryantownsend @krisquigley can this be prioritised please

@emma5678
Copy link
Author

emma5678 commented Nov 5, 2019

@ryantownsend @krisquigley Can this be prioritised asap please

@ryantownsend
Copy link
Contributor

@emma5678 this isn't actually executed in production so it's not really a major issue - it's a tool that runs a server to generate documentation, but we don't actually use it. Still, we should address it – I'll get it on the wall.

@emma5678
Copy link
Author

emma5678 commented Nov 5, 2019

@ryantownsend Does it actually need to be there then? Can we remove it if its never used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants