Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Penthouse to be Compatible with Active Record 5.2 #15

Open
3 tasks
simonireilly opened this issue Oct 11, 2019 · 0 comments · May be fixed by #21
Open
3 tasks

Upgrade Penthouse to be Compatible with Active Record 5.2 #15

simonireilly opened this issue Oct 11, 2019 · 0 comments · May be fixed by #21

Comments

@simonireilly
Copy link

Some of the alias methods inside the Migrator have been changed in Activerecord >= 5.2.

These changes were dealt with by Apartment, so we can take some inspiration here: https://github.com/influitive/apartment/pull/523/files

Acceptance Criteria

  • We can install Penthouse in a new Rails 6 application
  • We can install Penthouse in a new Rails 5.2 application
  • Two releases are prepared for the gem with semantic versioning used and release notes written.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@simonireilly