Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color Conversion Is Inaccurate #2

Open
pwood opened this issue Dec 20, 2020 · 0 comments
Open

Color Conversion Is Inaccurate #2

pwood opened this issue Dec 20, 2020 · 0 comments

Comments

@pwood
Copy link
Member

pwood commented Dec 20, 2020

I'm unhappy with the behavour of the conversion of CIE xyY colors into HSV/RGB, and reversed. I'm not actually sure how well this is going to work anyway in ZDA, given that the Color cluster does not actually take the Lumance component of HSV or Y2 in xyY.

Any correction specific to ZDA must happen there, there may be other data available on the Zigbee devices which helps to calculate the Y2.
pwood added a commit that referenced this issue Dec 20, 2020
@pwood
Add implementations for convertible colours. This raises #2, as the x…
50350e2 
…yY color conversion seems suspect to me. It needs further investigation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pwood