-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Save" icon #341
Comments
Thanks for reporting. Personally I don't like this icon in either theme, especially with the newer 'partial download' and 'bittorrent' mimetype icons, both of which use a down arrow on a document. Aside from looking like a mimetype, the blue arrow looks too much like the Bittorrent icon, the gray arrow makes it feel inactive or disabled. If changing the arrow color, I think orange or red would be better as writing/saving can be a destructive action. I wonder if using a down arrow on an HDD/SDD icon would be better? Or some other sort of symbol or emblem. Any thoughts or idea would be appreciated. This might be worth opening an issue for upstream and something we could work on in elementary icons first. |
The style for this icon changed a few times upstream and I can't recall which one was there before, but when I started the LibreOffice elementary icon theme they were in sync. Using HDDs or SDDs for the 'save' metaphor feels quite oldschool (think: floppy) and these metaphors are not only lost on less-technical users (who might not know what a HDD looks like) but are also prone to getting out of date. In general I would say that If you're truly unhappy with the style of an icon or the metaphor report it upstream. After all, this theme is mostly a shim with some extras. |
Until a few years ago, the save icons in Elementary OS/Xubuntu operating systems, Libreoffice and the torrent icon were identical, with a blue downward arrow. My assumption was that therefore in Elementary OS and Libreoffice after that they changed the icon to a new one with a gray arrow, to avoid the sameness with the torrent icon. |
under the impression of what you wrote, now I'm really starting to see save icon in LibreOffice as disabled or inactive... |
Opened an issue for this upstream here (with a few more mockups of a new styles). |
Hi LibreOffice icons maintainer here. Personally I prefer disket for save icon as it widely accepted though is not technically ideal. For elementary, I always try to keep sync up with upstream. The save icons in LibreOffice has different state. Previously, blue arrow indicates saved or unchanged document and red allow indicates unsaved one. Now they are the same grey down arrows with additional red circle below for unsaved state. |
@rizmut Sorry for the late response! I really enjoy and appreciate the work you've done on LibreOffice. You've done a really great job keeping LibreOffice looking nicer all the time (and I've read and enjoyed some of your UI blogs before)! So thank you! I like the diskette as well, but that idea has been shot down by all maintainers and some users, so it's not very popular I guess haha. I do like the idea of different icons for the different save states like LibreOffice uses. I wish FreeDesktop would add that to the spec and/or more editors would use it. We did talk a little more about the save icon upstream here and decided (I think) at least on a new Save Document icon; one that matches more the newer upstream document action style, like Document Import/Export. The upstream PR for that is here if you'd like to take a look and/or comment. Danielle Fore suggested the same down arrow with a folder for "Save As" since it brings up the folder chooser, which makes sense. But I tried a few versions of that and it didn't look great to me. So any other ideas for that from anyone would be appreciated. I'll try again with the folder thing eventually, maybe it'll turn out better next time I try. |
New `document-save` and `document-save-as` icons from upstream. "Save" uses new rounded-square "document action" (similar to the new import/export) "Save as" uses the arrow into folder Closes shimmerproject#341
The changes for this were finalized upstream, made PR #437 for it to pull from upstream if anyone would like to check it out. Example from upstream: |
In Elementary OS and Libreoffice (with elementary icon theme) icon for save document is with the gray down arrow, not the blue one anymore. Have you thought about adopting this change?
The text was updated successfully, but these errors were encountered: