Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise Puppet logging #40

Open
michaeldiender-shinesolutions opened this issue May 22, 2017 · 2 comments
Open

Optimise Puppet logging #40

michaeldiender-shinesolutions opened this issue May 22, 2017 · 2 comments
Assignees

Comments

@michaeldiender-shinesolutions
Copy link
Contributor

michaeldiender-shinesolutions commented May 22, 2017

suggest that we pass in the --logdest option to puppet-apply commands with default value of syslog with ability to configure it to a file.
referring to the stack management jobs: export-backups, import-packages etc.

@cliffano
Copy link
Collaborator

This ticket is about ensuring that aem-tools actions write to a log destination. This will be done as part of stack-provisioner (aws-related actions) and aem_curator (aem-related actions).

Destination is unlikely to be syslog at this point of time since the rest of the logs are written to filesystem and sent to CloudWatch. A separate effort will be needed to migrate everything to syslog.

@cliffano
Copy link
Collaborator

Since the introduction of Stack Manager, we also have to ensure that Puppet logging to filesystem does not swallow the stdout, because we still want the stdout for stack manager logging purpose.
Remember that user will use Stack Manager log (which is presented right away on their CI/CD tool) much more frequently instead of SSH-ing into the machine to check the logs, or using AWS console to check the CloudWatch logs.

If we can only pick one between writing to file vs stdout, keep stdout.

@cliffano cliffano changed the title puppet apply logging Optimise Puppet logging Mar 28, 2018
@cliffano cliffano self-assigned this Mar 28, 2018
ovlords added a commit that referenced this issue May 23, 2018
cliffano pushed a commit that referenced this issue May 24, 2018
* Add param to enable launch configuration default to be set to the live snapshot type.  (See aem-aws-stack-builder #40)

* Add comment about launch configuration default.

* Align arrows to keep syntax consistent.

* Test for the existence of the snapshot_id before execution. A precautionary measure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants