Store config errors and warnings into Configuration attributes #1984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Errors and warnings are now logged into files in a single step. Moreover, these traces can now be collected from external applications after spawning Arbiter instances and validating configs.
While they are no longer stored into config objects, they are still written to Shinken logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both @mgarcian and me modified all classes regarding to Shinken object definitions in order to store configuration errors and warnings into instances of these classes. These errors are lifted up to
Configurationinstances so they are gathered up together into a single place.Users are now capable of validating Shinken configurations by spawning
Arbiterinstances in a programmatic manner and collect config errors and warnings to perform some sort of post-processing over them.