Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect comma #1996

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joshhodgson
Copy link

The checks don't process correctly with commas. The check also doesn't return a comma. This appears to have been copied from old Nagios documentation which is also incorrect

The checks don't process correctly with commas. The check also doesn't return a comma. This appears to have been copied from old Nagios documentation which is also incorrect
@geektophe
Copy link
Collaborator

Hello, thank you for your contribution.

I had a look, and everywhere the performance metrics are coma separated. Could you point us where you saw it's different ?

@joshhodgson
Copy link
Author

Hi, I've just spun up a Nagios instance and you can see the default checks do not use commas
image
image
and from experience (though no screenshot because I've left the org) Shinken treats the comma as part of the performance data, making it unreadable by any metrics graphing solutions. I'll try and spin up a Shinken to show this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants