Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Talos has an extra fire extinguisher cabinet in the Crew Quarters #3305

Closed
TheVekter opened this issue Aug 24, 2024 · 0 comments · Fixed by #3307
Closed

[BUG] Talos has an extra fire extinguisher cabinet in the Crew Quarters #3305

TheVekter opened this issue Aug 24, 2024 · 0 comments · Fixed by #3307
Labels
Bug Something isn't working

Comments

@TheVekter
Copy link
Contributor

Round ID: 2626

Testmerges:

#3145: 'Destructible Walls' by Gristlebee at commit a1e67a7
#3094: 'tweaks to recoil and spread' by FalloutFalcon at commit dbae8b5
#2988: 'Claymores & Mine Tweaks' by Sun-Soaked at commit c18e1e8
#3238: 'refresh:clip p.3/frontiersmenening p.2: clip vs frontiersmen' by rye-rice at commit e21d8c3
#3249: 'Back In Black (Market) - Black Market Dead Drops and Stock Cycling' by Gristlebee at commit feaf91f
#3246: 'Atlas-class Light Armored Crusier' by meemofcourse at commit f6db2ef
#3220: 'TEG efficiency code tweaks.' by Thera-Pissed at commit 8c32603
#3210: 'Giving-the-PGF-some-more-love (PGF Cold Protections and Crying Sun Changes)' by DIB-DOG at commit 4acfaf6
#3136: 'New Waste Ruin: Abandoned Miskilamo Shipbreaking Yard' by Thera-Pissed at commit 2e34114
#3219: 'an attempt to fix orbit menu' by FalloutFalcon at commit d29a2b2
#3266: 'makes lighting a bit moodier' by tmtmtl30 at commit 336f4ad

image

@TheVekter TheVekter added the Bug Something isn't working label Aug 24, 2024
github-merge-queue bot pushed a commit that referenced this issue Aug 25, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

Someone put an extra fire extinguisher on the IRMV Talos in the crew
area on the exact same spot as the APC. It's gone now.

Before:

![361094061-bfe52a48-e487-4cc8-b4d3-7fb02705d3ca](https://github.com/user-attachments/assets/7cb71846-75df-4a01-848b-f4af26be1653)

After:

![image](https://github.com/user-attachments/assets/c57e4a2d-a44b-48f1-8e3c-4853940eb53c)

Fixes #3305

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game

I'd like to be able to click the APC without grabbing a fire
extinguisher

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl: Vekter
fix: Removed an extra fire extinguisher from the crew quarters on the
IRMV Talos.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this issue Aug 26, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

Someone put an extra fire extinguisher on the IRMV Talos in the crew
area on the exact same spot as the APC. It's gone now.

Before:

![361094061-bfe52a48-e487-4cc8-b4d3-7fb02705d3ca](https://github.com/user-attachments/assets/7cb71846-75df-4a01-848b-f4af26be1653)

After:

![image](https://github.com/user-attachments/assets/c57e4a2d-a44b-48f1-8e3c-4853940eb53c)

Fixes shiptest-ss13#3305

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game

I'd like to be able to click the APC without grabbing a fire
extinguisher

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl: Vekter
fix: Removed an extra fire extinguisher from the crew quarters on the
IRMV Talos.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant