Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]Safeties work on more slots #3341

Open
rye-rice opened this issue Sep 8, 2024 · 0 comments
Open

[FEATURE]Safeties work on more slots #3341

rye-rice opened this issue Sep 8, 2024 · 0 comments
Labels
Feature REALLY causes more bugs in the future that we won't know about.

Comments

@rye-rice
Copy link
Member

rye-rice commented Sep 8, 2024

Name of feature:

Title

Additional Info:

This is more so I don't know how to do this without it being messy

Have safeties be togglable in the
Active hand
Inactive hand
Belt slot
Pocket slots
Suit storage slots

Currently it's only toggable in the hands, if one could make it toggable in these other slots, it would be very appreciated

@rye-rice rye-rice added the Feature REALLY causes more bugs in the future that we won't know about. label Sep 8, 2024
github-merge-queue bot pushed a commit that referenced this issue Sep 9, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->
#3341 
Gun safeties can be toggled in 1st level storage slot (e.g hands, suit
slots, belts, pockets, back) instead of just the hands. Guns in
containers (e.g. backpacks) aren't togglable.

## Why It's Good For The Game

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

Seems like a nice QOL thing to have.

## Changelog

:cl:
add: Gun safeties can be toggled from 1st level storage slots.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this issue Sep 11, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->
shiptest-ss13#3341 
Gun safeties can be toggled in 1st level storage slot (e.g hands, suit
slots, belts, pockets, back) instead of just the hands. Guns in
containers (e.g. backpacks) aren't togglable.

## Why It's Good For The Game

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

Seems like a nice QOL thing to have.

## Changelog

:cl:
add: Gun safeties can be toggled from 1st level storage slots.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature REALLY causes more bugs in the future that we won't know about.
Projects
None yet
Development

No branches or pull requests

1 participant