Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE]: Add ko as builder #1444

Closed
1 task done
oliverbaehler opened this issue Dec 7, 2023 · 2 comments
Closed
1 task done

[FEATURE]: Add ko as builder #1444

oliverbaehler opened this issue Dec 7, 2023 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@oliverbaehler
Copy link

Is there an existing feature request for this?

  • I have searched the existing feature requests

Is your feature request related to a problem or use-case? Please describe.

For go projects we use ko.build to build controller images:
https://github.com/ko-build/ko

The question is, if ko.build should be supported as builder by shipwright.

Describe the solution that you would like.

Integrate a new builder for ko.build

Describe alternatives you have considered.

Not using ko.build

Anything else?
@oliverbaehler oliverbaehler added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 7, 2023
@qu1queee
Copy link
Contributor

qu1queee commented Dec 7, 2023

hello, thanks for reaching out, is your feature request addressed by the following example ?

@oliverbaehler
Copy link
Author

yes, thanks @qu1queee. Missed that example, sorry :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Shipwright Overview
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@qu1queee @oliverbaehler