Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BETA API] Some Go fields use a name that does not match the name of the JSON field #1484

Closed
1 task done
SaschaSchwarze0 opened this issue Feb 5, 2024 · 0 comments · Fixed by #1504
Closed
1 task done

[BETA API] Some Go fields use a name that does not match the name of the JSON field #1484

SaschaSchwarze0 opened this issue Feb 5, 2024 · 0 comments · Fixed by #1504
Assignees
@SaschaSchwarze0
Labels
beta BETA related issue good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Milestone
release-v0.13.0

Comments

@SaschaSchwarze0
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Kubernetes Version

No response

Shipwright Version

Latest

Current Behavior

We have some Go types where the rule to name the field the same as the JSON field (expect case) was broken. In particular here:

build/pkg/apis/build/v1beta1/source.go

Line 104 in ea6018e

GitSource *Git `json:"git,omitempty"`
But worth double-checking other places.

Expected Behavior

No response

Steps To Reproduce

No response

Anything else?

No response
@SaschaSchwarze0 SaschaSchwarze0 added the kind/bug Categorizes issue or PR as related to a bug. label Feb 5, 2024
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.13.0 milestone Feb 5, 2024
@SaschaSchwarze0 SaschaSchwarze0 added the beta BETA related issue label Feb 5, 2024
@qu1queee qu1queee added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Feb 8, 2024
@qu1queee qu1queee assigned qu1queee and SaschaSchwarze0 and unassigned qu1queee Feb 22, 2024
@SaschaSchwarze0 SaschaSchwarze0 mentioned this issue Feb 24, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SaschaSchwarze0 SaschaSchwarze0

Labels
beta BETA related issue good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Projects
Shipwright Overview
Status: Done
Milestone
release-v0.13.0
2 participants
@qu1queee @SaschaSchwarze0