Bump Tekton #1671
Merged
Bump Tekton #1671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaschaSchwarze0
added
the
kind/dependency-change
openshift-ci
bot
added
the
release-note
SaschaSchwarze0
force-pushed
the
sascha-bump-tekton
branch
from
ddc109d
to
af2aafe
Compare
SaschaSchwarze0
force-pushed
the
sascha-bump-tekton
branch
2 times, most recently
from
131af56
to
90d90bc
Compare
karanibm6
force-pushed
the
sascha-bump-tekton
branch
from
7d3dbe2
to
6da795a
Compare
openshift-merge-robot
added
the
needs-rebase
4 tasks
SaschaSchwarze0
force-pushed
the
sascha-bump-tekton
branch
from
a18ca39
to
c382428
Compare
openshift-merge-robot
removed
the
needs-rebase
Signed-off-by: Sascha Schwarze <[email protected]>
Signed-off-by: Sascha Schwarze <[email protected]>
Signed-off-by: Sascha Schwarze <[email protected]>
Signed-off-by: Sascha Schwarze <[email protected]>
Signed-off-by: Sascha Schwarze <[email protected]>
SaschaSchwarze0
force-pushed
the
sascha-bump-tekton
branch
from
c382428
to
774fc6c
Compare
Signed-off-by: Sascha Schwarze <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qu1queee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I picked the commit from #1664 and made the version of Kubernetes libraries and the Go version consistent. Karan bumped controller-gen.
The 73a8da7 commit is interesting. The integration tests failed on the older Tekton version. Basically the test case retrieved an existing TaskRun from a v0.53 tekton and deserialized it into the v0.62 object. It then applied spec changes and serializes it again to send an update. The update was rejected by Tekton's mutating webhook because it was unable to deserialize this object due to a new property being added in the status. It was only in the status, so I could simply clear it which is not relevant for the update. But, once we observe the same in the future with anything in the spec we may have to revisit our decision to use the latest available LTS version in go.mod rather than the oldest supported LTS version.
Submitter Checklist
Release Notes