Add Tolerations to Build and BuildRun objects

[dorzel]

Changes

Fixes #1636

Submitter Checklist

• Includes tests if functionality changed/was added
• Includes docs if changes are user-facing
• Set a kind label on this PR
• Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Add Tolerations to Build and BuildRun objects

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign heavywombat for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dorzel]

/kind feature

[dorzel]

Ok, this is ready for review/discussion.

I was unsure how the implementation should look for the strategic merge json patch mentioned in https://github.com/shipwright-io/community/blob/main/ships/0039-build-scheduler-opts.md#tolerations

This currently works and patches the BuildRun/Build object:

kubectl patch BuildRun <buildrun-name> --type=merge -p '{"spec":{"tolerations":[{"key":"test-key-patch","operator":"Equal","value":"test-value-patch"}]}}' -n test-ns

But didn't know if that was all that was required or what that should ideally look like.

Also looking for input on what implementing the subset of tolerations functionality should ideally look like, or if the current implementation is ok (failing validation if unsupported fields are specified/ always setting "NoSchedule").

I've also left the validaitons on the Shipwright end to enforce the simpler requirements here, and let Kubernetes do the rest of the toleration validation with the full ruleset.

[dorzel]

Bit stumped on the failing integration tests - after several revisions I can't find why the taint effect isn't getting set. It also looks like the e2e tests are running out of disk space.

[SaschaSchwarze0]

Trying to remove nested ifs.

Suggested change

	if toleration.Effect != v1.TaintEffectNoSchedule {
	if !(len(toleration.Effect) > 0) {
	// Effect was not specified, set it to the supported default
	b.Build.Spec.Tolerations[i].Effect = v1.TaintEffectNoSchedule
	} else {
	b.Build.Status.Reason = ptr.To(build.TolerationNotValid)
	b.Build.Status.Message = ptr.To(fmt.Sprintf("Only the '%v' toleration effect is supported.", v1.TaintEffectNoSchedule))
	}
	}
	switch (toleration.Effect) {
	case "":
	// Effect was not specified, set it to the supported default
	b.Build.Spec.Tolerations[i].Effect = v1.TaintEffectNoSchedule
	case v1.TaintEffectNoSchedule:
	// Allowed value
	default:
	b.Build.Status.Reason = ptr.To(build.TolerationNotValid)
	b.Build.Status.Message = ptr.To(fmt.Sprintf("Only the '%v' toleration effect is supported.", v1.TaintEffectNoSchedule))
	}

[SaschaSchwarze0]

Because of node taints

Suggested change

	Context("when tolerations are specified", func() {
	Context("when tolerations are specified", Serial, func() {