Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Operator reports "Ready: True" when TektonConfig reports "Error" #167

Open
1 task done
adambkaplan opened this issue Oct 31, 2023 · 3 comments
Open
1 task done
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@adambkaplan
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Kubernetes Version

v1.25 or higher

Shipwright Version

v0.12.0 (and earlier)

Current Behavior

When the TektonConfig object (existing, or created by the Shipwright operator) reports its status as Error/not available, the ShipwrightBuild object only reports its status condition as "Ready: True".

Expected Behavior

ShipwrightBuild should either report a status condition of "Ready: False", or report a new status condition like "Available" which is used to convey the overall health of the system.

Steps To Reproduce

  1. Deploy OLM on Kubernetes 1.25 or higher (ex - with KinD)
  2. Deploy the Shipwright Operator using the operatorhub.io catalog - ensure it uses Tekton Operator v0.61 or lower
  3. Create a ShipwrightBuild instance

Anything else?

Related to tektoncd/operator#1493 - the Tekton Operator in operatorhub is currently obsolete and breaks on k8s 1.25 or higher.

@adambkaplan adambkaplan added the kind/bug Categorizes issue or PR as related to a bug. label Oct 31, 2023
@adambkaplan adambkaplan added this to the Backlog milestone Nov 20, 2023
@SaschaSchwarze0
Copy link
Member

@adambkaplan is this something blocking that we should address for v0.13 ?

@adambkaplan
Copy link
Member Author

I would not consider this blocking for v0.13.0

@adambkaplan
Copy link
Member Author

From backlog refinement: We should wait until #139 is addressed before taking this on. Upgrading operator-sdk will involve a significant refactor of the operator code itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
Status: Todo
Development

No branches or pull requests

2 participants