Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Handle deletion of roles for webhook deployment #181

Closed
1 task done
SaschaSchwarze0 opened this issue Jan 8, 2024 · 2 comments · Fixed by #214
Closed
1 task done

[FEATURE] Handle deletion of roles for webhook deployment #181

SaschaSchwarze0 opened this issue Jan 8, 2024 · 2 comments · Fixed by #214
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@SaschaSchwarze0
Copy link
Member

Is there an existing feature request for this?

  • I have searched the existing feature requests

Is your feature request related to a problem or use-case? Please describe.

We shipped Shipwright Build v0.12.0 with a cluster role and a binding for the webhook that are unnecessary. To follow least-privilege principle, we removed them in shipwright-io/build#1448.

The operator must handle the deletion.

Describe the solution that you would like.

When updating v0.13.0, the operator should delete the clusterrole shipwright-build-webhook and the clusterrolebinding shipwright-build-webhook.

Describe alternatives you have considered.

No response

Anything else?

No response

@adambkaplan
Copy link
Member

/close

Fixed in #214

@openshift-ci openshift-ci bot closed this as completed Jun 13, 2024
Copy link
Contributor

openshift-ci bot commented Jun 13, 2024

@adambkaplan: Closing this issue.

In response to this:

/close

Fixed in #214

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
Status: Done
4 participants