Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks #1

Open
sojusnik opened this issue Aug 28, 2019 · 2 comments
Open

Tweaks #1

sojusnik opened this issue Aug 28, 2019 · 2 comments

Comments

@sojusnik
Copy link

Thanks for updating this great plugin!

Unfortunately, it doesn't work well with Zim v0.71.1 on Ubuntu 19.04 – tags don't get filtered when typing and tab doesn't work as well.

Did you know that there is already an updated version of this plugin, but with a cosmetic flaw? This PR could be also relevant for your plugin.

@shivams
Copy link
Owner

shivams commented Aug 28, 2019

@sojusnik Thanks for the issues. And thanks for informing about the existing plugin; I didn't know it existed.

Anyways, you have mentioned 2 issues:

1 : Filtering while Typing

I just checked and yes the filtering doesn't happen while typing. I will see to it.

2 : TAB Key Issue

TAB key does seem to work. Perhaps, you can try configuring the TAB key to function in the way you desire, as shown in the screenshot:
image
Let me know if this resolves the TAB issue for you.

@sojusnik
Copy link
Author

I just checked and yes the filtering doesn't happen while typing. I will see to it.

Still doesn't work in Zim v0.72.0 with v0.94.

Without filtering, this plugin is practically useless. The only working version is this.

TAB key does seem to work. Perhaps, you can try configuring the TAB key to function in the way you desire, as shown in the screenshot:

TAB works for selecting and cycling, but the latter could be improved:

  1. While cycling, the highlighting isn't following the selected tag if it's within the visible area of the popup, but it does so when using UP and DOWN for cycling.

  2. If bottom is reached, it could start again from top.

The popup has a wired offset. Why not align the first tag in the popup with the text line where the tag should be inserted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants