From 8c8598f04d0ba398616edaa9f9ae1da26d1afa9d Mon Sep 17 00:00:00 2001 From: Shiv Jha-Mathur Date: Tue, 20 Aug 2024 20:30:38 +0530 Subject: [PATCH] ci: build for Node v20 and v22 --- .github/workflows/publish.yml | 2 +- README.md | 19 +++++-------------- 2 files changed, 6 insertions(+), 15 deletions(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index ba88c35..21e8781 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -20,7 +20,7 @@ jobs: strategy: matrix: base: [alpine, debian] - node: [12, 14, 16, 17, 18, 19] + node: [12, 14, 16, 17, 18, 19, 20, 22] steps: - uses: actions/checkout@v3 - name: Set up Docker Buildx diff --git a/README.md b/README.md index 6712d70..3476dbd 100644 --- a/README.md +++ b/README.md @@ -2,9 +2,7 @@ [![Build and publish to Docker Hub](https://github.com/shivjm/docker-node-chromium/actions/workflows/publish.yml/badge.svg)](https://github.com/shivjm/docker-node-chromium/actions/workflows/publish.yml) ![https://hub.docker.com/r/shivjm/node-chromium](https://img.shields.io/docker/pulls/shivjm/node-chromium) -A Docker image with preinstalled Chromium and Node.JS on Alpine Linux -or Debian. Good minimal base image for users of scraping libraries -like [Puppeteer](https://github.com/GoogleChrome/puppeteer/). +A Docker image with preinstalled Chromium and Node.JS on Alpine Linux or Debian. Good minimal base image for users of scraping libraries like [Puppeteer](https://github.com/GoogleChrome/puppeteer/). ## Repository @@ -16,17 +14,15 @@ https://github.com/shivjm/docker-node-chromium/issues/ ## Tags -See all available tags at [Docker Hub -(shivjm/node-chromium)](https://hub.docker.com/r/shivjm/node-chromium). -No `latest` image is provided. +See all available tags at [Docker Hub (shivjm/node-chromium)](https://hub.docker.com/r/shivjm/node-chromium). No `latest` image is provided. ### Alpine Linux -nodeN-chromiumC-alpine, where N is the Node.js major version number (12, 14, 16, 17, 18, or 19) and C is the Chromium major version number. For example, to use Node.js 14 with Chromium 81, use the `shivjm/node-chromium:node14-chromium81-alpine` image. +nodeN-chromiumC-alpine, where N is the Node.js major version number (12, 14, 16, 17, 18, 19, 20, or 22) and C is the Chromium major version number. For example, to use Node.js 14 with Chromium 81, use the `shivjm/node-chromium:node14-chromium81-alpine` image. ### Debian -nodeN-chromiumC-debian, where N is the Node.js major version number (12, 14, 16, 17, 18, or 19) and C is the Chromium major version number. For example, to use Node.js 14 with Chromium 81, use the `shivjm/node-chromium:node14-chromium81-debian` image. +nodeN-chromiumC-debian, where N is the Node.js major version number (12, 14, 16, 17, 18, 19, 20, or 22) and C is the Chromium major version number. For example, to use Node.js 14 with Chromium 81, use the `shivjm/node-chromium:node14-chromium81-debian` image. ## Versioning @@ -88,12 +84,7 @@ ENTRYPOINT ["npm", "start", "--quiet"] ## Puppeteer -When you install Puppeteer, it also downloads a known version of -Chromium to store under node_modules, and defaults to using that -binary. You can skip this download using the environment variable -`PUPPETEER_SKIP_CHROMIUM_DOWNLOAD`. You’ll also need to set -`PUPPETEER_EXECUTABLE_PATH` to the installed Chromium. A partial -example: +When you install Puppeteer, it also downloads a known version of Chromium to store under node_modules, and defaults to using that binary. You can skip this download using the environment variable `PUPPETEER_SKIP_CHROMIUM_DOWNLOAD`. You’ll also need to set `PUPPETEER_EXECUTABLE_PATH` to the installed Chromium. A partial example: ```Dockerfile # (setup elided)