Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request - Support for cardsets with arbitrary number of ranks and suits. #410

Open
Alucard648 opened this issue Nov 5, 2024 · 9 comments

Comments

@Alucard648
Copy link

Title says all. I found many crazy decks with, like 16 ranks and 16 suits + jokers. Here is one:
cardset-master.zip
French uses 13 ranks and 4 suits, Hex-A-Deck uses 16 ranks and 4 suits (+ 4 ranked jokers), Hanafuda uses 4 ranks and 12 suits, Ganjifa decks use 12 ranks and 8 or 10 suits. And so on. We are hoping that some original decks of cards can be used in many crazy solitaire games.

@joeraz
Copy link
Collaborator

joeraz commented Nov 5, 2024

A cardset type is more than just a number of suits/ranks/trumps. There are the base bottom images, find card images, and compatibility rules that determine which games can be played with which cardsets.

I am definitely willing to add more cardset types, including original ones. There was previously some discussion about trying to get a sixteen-suit deck supported. I also tried to get Politaire's six and eight suit decks added, but I lack the image editing support needed to get those to work. While I can do some of the images myself, my own image-editing skills are only passable, so I would need support from someone good at graphics.

At bare minimum, to add a new cardset type, I would need:

  • At least three appropriately licensed cardsets - one lower res in the style of earlier versions of PySol for smaller screens, one high res for more modern displays (in the style of https://github.com/joeraz/neo-cards if possible), and one other for some variation.
  • Images for the global cardset bottoms/find card display.
  • A number of examples of games that would use the new cardset type. I really don't want to add a whole new cardset type for a single game (unless there are a lot of variants of said game).

If I can get support with those three things, I'll be more than happy to help get more original cardset types in.

@Alucard648
Copy link
Author

Thanks for roadmap. Will work on it further. For kick start, feel free to use bottoms from this cardset. Actually I did it.

@Alucard648
Copy link
Author

Card search table.
search

@Alucard648
Copy link
Author

Alucard648 commented Nov 6, 2024

Also here is my SVG file used for making cardset:
карты

Russian and English index languages are available in this file.
Feel free to downscale it for low-res cardset and upscale for hi-res thing done. Hope you are good with Inkscape.

@joeraz
Copy link
Collaborator

joeraz commented Nov 6, 2024

I am not that good with Inkscape. I can export images at various sizes, and sometimes rescale them (with considerable difficulty), but when I try to do something else, it never acts how I expect. I do know how to slice images after they export, but not all images slice cleanly.

For bottoms, I'm also looking for the standard cardset bottoms - the images currently in data/images/cards/bottoms.

@Alucard648
Copy link
Author

Alucard648 commented Nov 6, 2024

For image to slice properly, his size, in pixels, must be divisible, in both width and height, by number of cards in sheet. If not, sheet must be cropped to exact size. Also cards in sheet must have no gaps in between. Tools used to make the afromentioned cardset are listed in Copyright info file.

The real pain for me was renaming 320 output files manually to suit PySolFC needs. Cardset Maker (latest version) don`t support non-French decks at all. He can only autogenerate drop shadow images, which is still helpful.

@Alucard648
Copy link
Author

Base bottom images.
master_base_bottom.zip

@Alucard648
Copy link
Author

And here is what I have done for this cardset type:

  • 4 variants of default Master cardset, with English/Russian indexes and low/high definition.
  • False Dominoes 16x16 cardset inspired by dominoes. Top half is card rank, bottom half is card suit.
  • Card search and base bottom images.
  • And text file containing ides for 16 solitaire games. Unfortunately, they are mostly adaptations of classic solitaire games, sometimes with crazy twists, like special card placement and non-standard victory conditions.

master_deck.zip

@joeraz
Copy link
Collaborator

joeraz commented Nov 10, 2024

I'll see what I can prototype with that, though it will take some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants