Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow storage of access tokens #15

Open
fschmtt opened this issue Oct 10, 2024 · 1 comment
Open

Allow storage of access tokens #15

fschmtt opened this issue Oct 10, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@fschmtt
Copy link
Member

fschmtt commented Oct 10, 2024

Would be helpful if the SDK would allow to

  • store access tokens
  • pass in an access token to the HTTP client
@fschmtt fschmtt added enhancement New feature or request good first issue Good for newcomers labels Oct 10, 2024
@shyim
Copy link
Member

shyim commented Oct 11, 2024

I would not allow passing an access token to the http client. I would pass an accesstokeninterface optional to the constructor and fetch the token itself in the client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fschmtt @shyim