Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add more flexibility to the useOrderDetails #1472

Open
mdanilowicz opened this issue Nov 20, 2024 · 0 comments
Open

[FEATURE] Add more flexibility to the useOrderDetails #1472

mdanilowicz opened this issue Nov 20, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@mdanilowicz
Copy link
Collaborator

Description

Currently, the useOrderDetails composable has 2 roles:

Data provider - loadOrderDetails method by orderID that is a "constructor" parameter
Business logic executor - methods allowing actions on the order object.

This assumption is problematic because:

  • Order data can be already fetched by different data providers (order email success page)
  • Order can be identified not only by ID (deepLinkCode)

Solution:

  • Make useOrderDerails deprecated
  • Create orderDataProvider composable for fetching data
  • Create useOrderData? composable for getting data from the order

Use Case

.

Proposed Solution

No response

Alternatives Considered

No response

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

1 participant