diff --git a/packages/shorebird_cli/lib/src/artifact_builder.dart b/packages/shorebird_cli/lib/src/artifact_builder.dart index 59eb4accf..0ef3a1a1b 100644 --- a/packages/shorebird_cli/lib/src/artifact_builder.dart +++ b/packages/shorebird_cli/lib/src/artifact_builder.dart @@ -561,8 +561,6 @@ Either run `flutter pub get` manually, or follow the steps in ${cannotRunInVSCod 'build', 'windows', '--release', - if (flavor != null) '--flavor=$flavor', - if (target != null) '--target=$target', ...args, ]; @@ -570,7 +568,8 @@ Either run `flutter pub get` manually, or follow the steps in ${cannotRunInVSCod executable, arguments, runInShell: true, - environment: base64PublicKey?.toPublicKeyEnv(), + // TODO(bryanoltman): support this + // environment: base64PublicKey?.toPublicKeyEnv(), ); buildProcess.stdout diff --git a/packages/shorebird_cli/test/src/commands/preview_command_test.dart b/packages/shorebird_cli/test/src/commands/preview_command_test.dart index 9aa77464f..ecd685765 100644 --- a/packages/shorebird_cli/test/src/commands/preview_command_test.dart +++ b/packages/shorebird_cli/test/src/commands/preview_command_test.dart @@ -1882,6 +1882,24 @@ channel: ${DeploymentTrack.staging.channel} }); }); + group('when downloading release artifact fails', () { + setUp(() { + when( + () => artifactManager.downloadFile(any()), + ).thenThrow(Exception('oops')); + }); + + test('returns code 70', () async { + final result = await runWithOverrides(command.run); + expect(result, equals(ExitCode.software.code)); + verify( + () => artifactManager.downloadFile( + Uri.parse(releaseArtifactUrl), + ), + ).called(1); + }); + }); + group('when preview artifact is not cached', () { setUp(() { when(() => artifactManager.downloadFile(any()))