From 244c537492a7657a55f9817f76ab160ef9c13fc4 Mon Sep 17 00:00:00 2001 From: Elliot Shepherd Date: Wed, 27 Nov 2024 19:39:11 +1100 Subject: [PATCH 1/4] fix: "SYS_KEYS has no physical keys " error on preview "** SYS_KEYS has no physical keys but with factor 2.0%." --- packages/shorebird_cli/lib/src/executables/adb.dart | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/shorebird_cli/lib/src/executables/adb.dart b/packages/shorebird_cli/lib/src/executables/adb.dart index 3c8f93247..42a032aec 100644 --- a/packages/shorebird_cli/lib/src/executables/adb.dart +++ b/packages/shorebird_cli/lib/src/executables/adb.dart @@ -51,6 +51,7 @@ class Adb { if (deviceId != null) ...['-s', deviceId], 'shell', 'monkey', + '--pct-syskeys 0', '-p $package', '1', ]; From 727a7d36d974c20ee1d46815473e2a37a54c535a Mon Sep 17 00:00:00 2001 From: Felix Angelov Date: Tue, 14 Jan 2025 12:24:58 -0600 Subject: [PATCH 2/4] chore: adjust tests --- packages/shorebird_cli/test/src/executables/adb_test.dart | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/shorebird_cli/test/src/executables/adb_test.dart b/packages/shorebird_cli/test/src/executables/adb_test.dart index 5176fd670..84e798fd8 100644 --- a/packages/shorebird_cli/test/src/executables/adb_test.dart +++ b/packages/shorebird_cli/test/src/executables/adb_test.dart @@ -157,7 +157,10 @@ void main() { completes, ); verify( - () => process.run(adbPath, 'shell monkey -p $package 1'.split(' ')), + () => process.run( + adbPath, + 'shell monkey --pct-syskeys 0 -p $package 1'.split(' '), + ), ).called(1); }); @@ -172,7 +175,8 @@ void main() { verify( () => process.run( adbPath, - '-s $deviceId shell monkey -p $package 1'.split(' '), + '-s $deviceId shell monkey --pct-syskeys 0 -p $package 1' + .split(' '), ), ).called(1); }); From 2fb363e74d90da798e931cedeb866277baf082e5 Mon Sep 17 00:00:00 2001 From: Felix Angelov Date: Tue, 14 Jan 2025 12:26:46 -0600 Subject: [PATCH 3/4] chore: comments --- packages/shorebird_cli/lib/src/executables/adb.dart | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/shorebird_cli/lib/src/executables/adb.dart b/packages/shorebird_cli/lib/src/executables/adb.dart index 42a032aec..46167e0e7 100644 --- a/packages/shorebird_cli/lib/src/executables/adb.dart +++ b/packages/shorebird_cli/lib/src/executables/adb.dart @@ -51,6 +51,8 @@ class Adb { if (deviceId != null) ...['-s', deviceId], 'shell', 'monkey', + // Adjust percentage of "system" key events to 0. + // This is needed to support Android systems with no hardware keys. '--pct-syskeys 0', '-p $package', '1', From d5384ddb6d7a5f42406f611ddb0b9e38685e1069 Mon Sep 17 00:00:00 2001 From: Felix Angelov Date: Tue, 14 Jan 2025 12:32:56 -0600 Subject: [PATCH 4/4] cspell --- cspell.config.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/cspell.config.yaml b/cspell.config.yaml index 096c09433..b3e915980 100644 --- a/cspell.config.yaml +++ b/cspell.config.yaml @@ -96,6 +96,7 @@ words: - SIGSTOP - storepass # From .github/workflows/e2e.yaml - storyboardc + - syskeys # From adb.dart - subosito # From .github dir, doesn't show up in "**" check? - swiftshader # From .github dir, doesn't show up in "**" check? - sysroot