Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mockgun: find_one / find does not support include_archived_projects param #164

Open
mfe opened this issue Jan 3, 2018 · 1 comment
Open

Comments

@mfe
Copy link

mfe commented Jan 3, 2018

The param is not defined so the mocked code will raise if some call are made with it.
As the default value is True, we actually have some of our core functions that set the value to false for optim purposes.

I fixed the issue in our version of Mockgun (by adding a silly include_archived_projects=True in the function proto), but thought it was worth mentioning :)
On the breaking API thematic, the same function is also missing the additional_filter_presets one.

Did I already said I ❤️ Mockgun ?

@manneohrstrom
Copy link
Contributor

hello @mfe - great that you are finding mockgun useful. If you have the time and got a fix, feel free to send us a pull request and we can merge it in! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants