{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":404086716,"defaultBranch":"master","name":"cockroach","ownerLogin":"shralex","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2021-09-07T18:41:05.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/6037719?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1704411810.0","currentOid":""},"activityList":{"items":[{"before":"1d53b699ce333a2e007084e577406b3b53fd93ea","after":"abd6d1e13ecacf8b63a911dee4795abafb12b65f","ref":"refs/heads/gossip_address","pushedAt":"2024-03-06T02:44:15.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"shralex","name":null,"path":"/shralex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6037719?s=80&v=4"},"commit":{"message":"gossip: when redirecting / forwarding connection requests, consider locality-advertise-addr\n\nPreviously,  when a gossip server rejects a connection request, it suggests an alternate node\nto connect to, which is returned in the connection response. However, the address of that node\ndoes not consider the locality of the connecting node. It is possible that the alternate\nnode has multiple addresses for multiple localities (locality-advertise-addr), and without\nknowing them the client might not be able to connect.\n\nWith this PR, when a connection is refused, we now return both the base address and the\nlocality-advertise-addr in the Response to the connecting client. It the chooses the first\nmatching address from locality-advertise-addr based on the client's own locality, or,\nif no match is found, uses the base address (this logic is in metadata.go, Locality.LookupAddress).\n\nRelease note (bug fix): when a gossip client attempts to connect to a server, but the connection\nis refused and an alternative server is suggested, that server's locality-advertise-addr is provided.\nThe client then picks an address from this list based on its own locality, and uses advertise-addr\nas a fall-back. This fixes a bug where, upon being redirected, the client always used the alternative\nnode's advertise-addr.\n\nFixes: https://github.com/cockroachdb/cockroach/issues/114430","shortMessageHtmlLink":"gossip: when redirecting / forwarding connection requests, consider l…"}},{"before":"087bcdd8d62b2d83f01fa190eba8189d5428d4dc","after":"1d53b699ce333a2e007084e577406b3b53fd93ea","ref":"refs/heads/gossip_address","pushedAt":"2024-03-05T22:09:38.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"shralex","name":null,"path":"/shralex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6037719?s=80&v=4"},"commit":{"message":"gossip: when redirecting / forwarding connection requests, consider locality-advertise-addr\n\nPreviously,  when a gossip server regects a connection request, it suggests an alternate node\nto connect to, which is returned in the connection response. However, the address of that node\ndoes not consider the locality of the connecting node. It is possible that the alternate\nnode has multiple addresses for multiple localities (locality-advertise-addr), and without\nknowing them the client might not be able to connect.\n\nWith this PR, when a connection is refused, we now return both the base address and the\nlocality-advertise-addr in the Response to the connecting client.\n\nFixes: https://github.com/cockroachdb/cockroach/issues/114430","shortMessageHtmlLink":"gossip: when redirecting / forwarding connection requests, consider l…"}},{"before":"ab0547bee3d5aa9783a9f791efb7436d27052a40","after":"087bcdd8d62b2d83f01fa190eba8189d5428d4dc","ref":"refs/heads/gossip_address","pushedAt":"2024-03-05T15:33:08.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"shralex","name":null,"path":"/shralex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6037719?s=80&v=4"}},{"before":"63f28112dc81b7ebc612c5068d9817a4557c0741","after":"ab0547bee3d5aa9783a9f791efb7436d27052a40","ref":"refs/heads/gossip_address","pushedAt":"2024-03-05T07:36:21.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"shralex","name":null,"path":"/shralex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6037719?s=80&v=4"}},{"before":"0688bfeb9ea37ce23cad4cc9c5f364fe7f35fbea","after":"63f28112dc81b7ebc612c5068d9817a4557c0741","ref":"refs/heads/gossip_address","pushedAt":"2024-03-05T07:32:03.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"shralex","name":null,"path":"/shralex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6037719?s=80&v=4"}},{"before":"95f9dda163498bb1a2372e665721309b08acb1c5","after":"0688bfeb9ea37ce23cad4cc9c5f364fe7f35fbea","ref":"refs/heads/gossip_address","pushedAt":"2024-03-04T02:11:38.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"shralex","name":null,"path":"/shralex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6037719?s=80&v=4"},"commit":{"message":"gossip: when redirecting / forwarding connection requests, consider locality-advertise-addr\n\nCurrently when a gossip server regects a connection request it suggests an alternate node\nto connect to, which is returned in the connection response. However, the address of that node\ndoes not consider the locality of the connecting node. It is possible that the alternate\nnode has multiple addresses for multiple localities (locality-advertise-addr), we should\nreturn the appropriate address.\n\nTo make this possible, this PR adds locality to the connection request. It still chooses\na node at random, but now selects the appropriate locality-advertise-addr. In the future\nwe could use the provided locality differently, for example by returning an alternate\nnode in the same locality as the client. However, this is not done here.\n\nFixes: https://github.com/cockroachdb/cockroach/issues/114430","shortMessageHtmlLink":"gossip: when redirecting / forwarding connection requests, consider l…"}},{"before":"17d34be88c3add662d186f08ffe3fe9780352ddb","after":"95f9dda163498bb1a2372e665721309b08acb1c5","ref":"refs/heads/gossip_address","pushedAt":"2024-03-04T02:08:42.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"shralex","name":null,"path":"/shralex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6037719?s=80&v=4"}},{"before":"a516b8aeaf713c8f68ff3eee81ddf686248197a3","after":"b03471454b4bc2bf2ff8217126259c0a17f6b15c","ref":"refs/heads/log_slow_requests","pushedAt":"2024-02-05T21:39:17.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"shralex","name":null,"path":"/shralex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6037719?s=80&v=4"},"commit":{"message":"kv: log slow requests on replica level in addition to range level\n\nPreviously, slow requests were only logged at the range level, but\nthe logs did not indicate which replica is slow. Moreover, the\nSlowRPC metric attempted to represent the number of requests\ncurrently being retried, however it was done on the range level\nand therefore missed a second level of replica-level retries being\ndone underneath.\n\nThis PR adds logging on the replica level, removes a confusing log\nline, and changes the metric to count the number of slow requests\nin a simpler manner.\n\nEpic: https://cockroachlabs.atlassian.net/browse/CRDB-33510\nFixes: https://github.com/cockroachdb/cockroach/issues/114431","shortMessageHtmlLink":"kv: log slow requests on replica level in addition to range level"}},{"before":"05f2ab215d5790afdd37b9fcbcb5c8b21c6f474b","after":"a516b8aeaf713c8f68ff3eee81ddf686248197a3","ref":"refs/heads/log_slow_requests","pushedAt":"2024-02-05T19:39:57.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"shralex","name":null,"path":"/shralex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6037719?s=80&v=4"}},{"before":"c515cb7a0c90b2e0a645847cd798f788e6ee320a","after":"05f2ab215d5790afdd37b9fcbcb5c8b21c6f474b","ref":"refs/heads/log_slow_requests","pushedAt":"2024-02-05T07:22:00.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"shralex","name":null,"path":"/shralex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6037719?s=80&v=4"}},{"before":"88d10632cabdb629e0ce2b3307e1041a62ab8f00","after":"c515cb7a0c90b2e0a645847cd798f788e6ee320a","ref":"refs/heads/log_slow_requests","pushedAt":"2024-02-04T05:13:32.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"shralex","name":null,"path":"/shralex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6037719?s=80&v=4"}},{"before":"66d10e8fd64db99daa6243362bddcaeca95b6ae0","after":"88d10632cabdb629e0ce2b3307e1041a62ab8f00","ref":"refs/heads/log_slow_requests","pushedAt":"2024-01-18T22:57:01.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"shralex","name":null,"path":"/shralex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6037719?s=80&v=4"}},{"before":"66af98c658e5e60b12e607a7e99021d85dcf57f7","after":"66d10e8fd64db99daa6243362bddcaeca95b6ae0","ref":"refs/heads/log_slow_requests","pushedAt":"2024-01-14T21:50:13.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"shralex","name":null,"path":"/shralex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6037719?s=80&v=4"}},{"before":"d69800fcfdf338c9b419889ab322d3cbc4302cf7","after":"17d34be88c3add662d186f08ffe3fe9780352ddb","ref":"refs/heads/gossip_address","pushedAt":"2024-01-09T08:08:18.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"shralex","name":null,"path":"/shralex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6037719?s=80&v=4"}},{"before":"b29a4215f5b72838e3f4c8d3f3571fb9c97cf373","after":"d69800fcfdf338c9b419889ab322d3cbc4302cf7","ref":"refs/heads/gossip_address","pushedAt":"2024-01-09T01:51:14.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"shralex","name":null,"path":"/shralex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6037719?s=80&v=4"}},{"before":"dd4f3054437b2efa137813fa83d4139d92d4d4d4","after":"b29a4215f5b72838e3f4c8d3f3571fb9c97cf373","ref":"refs/heads/gossip_address","pushedAt":"2024-01-07T13:18:27.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"shralex","name":null,"path":"/shralex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6037719?s=80&v=4"}},{"before":"afb2753f3953d3e2d7c9dd2560d7966eae4d0a89","after":"dd4f3054437b2efa137813fa83d4139d92d4d4d4","ref":"refs/heads/gossip_address","pushedAt":"2024-01-06T03:56:02.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"shralex","name":null,"path":"/shralex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6037719?s=80&v=4"}},{"before":null,"after":"afb2753f3953d3e2d7c9dd2560d7966eae4d0a89","ref":"refs/heads/gossip_address","pushedAt":"2024-01-04T23:43:30.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"shralex","name":null,"path":"/shralex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6037719?s=80&v=4"},"commit":{"message":"gossip: when redirecting / forwarding connection requests, consider locality-advertise-addr\n\nCurrently when a gossip server regects a connection request it suggests an alternate node\nto connect to, which is returned in the connection response. However, the address of that node\ndoes not consider the locality of the connecting node. It is possible that the alternate\nnode has multiple addresses for multiple localities (locality-advertise-addr), we should\nreturn the appropriate address.\n\nTo make this possible, this PR adds locality to the connection request. It still chooses\na node at random, but now selects the appropriate locality-advertise-addr. In the future\nwe could use the provided locality differently, for example by returning an alternate\nnode in the same locality as the client. However, this is not done here.\n\nFixes: https://github.com/cockroachdb/cockroach/issues/114430","shortMessageHtmlLink":"gossip: when redirecting / forwarding connection requests, consider l…"}},{"before":"ecc1a9912454984c4d6bb14bc8a6c178c940cb7c","after":"66af98c658e5e60b12e607a7e99021d85dcf57f7","ref":"refs/heads/log_slow_requests","pushedAt":"2024-01-04T20:11:36.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"shralex","name":null,"path":"/shralex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6037719?s=80&v=4"},"commit":{"message":"kv: log slow requests on replica level in addition to range level\n\nPreviously, slow requests were only logged at the range level, but\nthe logs did not indicate which replica is slow. Moreover, the\nSlowRPC metric attempted to represent the number of requests\ncurrently being retried, however it was done on the range level\nand therefore missed a second level of replica-level retries being\ndone underneath.\n\nThis PR adds logging on the replica level, removes a confusing log\nline, and changes the metric to count the number of slow requests\nin a simpler manner.\n\nEpic: https://cockroachlabs.atlassian.net/browse/CRDB-33510\nFixes: https://github.com/cockroachdb/cockroach/issues/114431","shortMessageHtmlLink":"kv: log slow requests on replica level in addition to range level"}},{"before":"145339d8ad067ea31f6d2b74536319fa37ea1250","after":"05049deba8acd6df175907599d3614323b8ad4a0","ref":"refs/heads/remove_gossip_log","pushedAt":"2024-01-03T18:27:22.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"shralex","name":null,"path":"/shralex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6037719?s=80&v=4"},"commit":{"message":"gossip: reduce verbosity of spammy message\n\nThis PR is lowering the verbosity of a Gossip-related log message.\n\nFixes: https://github.com/cockroachdb/cockroach/issues/115637","shortMessageHtmlLink":"gossip: reduce verbosity of spammy message"}},{"before":null,"after":"145339d8ad067ea31f6d2b74536319fa37ea1250","ref":"refs/heads/remove_gossip_log","pushedAt":"2023-12-30T20:09:33.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"shralex","name":null,"path":"/shralex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6037719?s=80&v=4"},"commit":{"message":"gossip: reduce verbosity of spammy message\n\nThis PR is lowering the verbosity of a Gossip-related log message.\n\nFixes: https://github.com/cockroachdb/cockroach/issues/115637","shortMessageHtmlLink":"gossip: reduce verbosity of spammy message"}},{"before":"b3dcc05380657d55804da63809563344403cae21","after":"ecc1a9912454984c4d6bb14bc8a6c178c940cb7c","ref":"refs/heads/log_slow_requests","pushedAt":"2023-12-27T18:21:30.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"shralex","name":null,"path":"/shralex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6037719?s=80&v=4"},"commit":{"message":"kv: log slow requests on replica level in addition to range level\n\nPreviously, slow requests were only logged at the range level, but\nthe logs did not indicate which replica is slow. Moreover, the\nSlowRPC metric attempted to represent the number of requests\ncurrently being retried, however it was done on the range level\nand therefore missed a second level of replica-level retries being\ndone underneath.\n\nThis PR adds logging on the replica level, removes a confusing log\nline, and changes the metric to count the number of slow requests\nin a simpler manner.\n\nEpic: https://cockroachlabs.atlassian.net/browse/CRDB-33510\nFixes: https://github.com/cockroachdb/cockroach/issues/114431","shortMessageHtmlLink":"kv: log slow requests on replica level in addition to range level"}},{"before":null,"after":"b3dcc05380657d55804da63809563344403cae21","ref":"refs/heads/log_slow_requests","pushedAt":"2023-12-27T17:36:56.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"shralex","name":null,"path":"/shralex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6037719?s=80&v=4"}},{"before":null,"after":"9405d5208642f9146195d58e644f60cfaff562d5","ref":"refs/heads/guardrailsfix","pushedAt":"2023-03-25T17:26:56.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"shralex","name":null,"path":"/shralex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6037719?s=80&v=4"},"commit":{"message":"kvserver: skip TestBackpressureNotAppliedWhenReducingRangeSize under race\n\nFixing an omission in https://github.com/cockroachdb/cockroach/pull/96725\nthis test sends snapshots and takes many minutes under race. This PR skips\nit.\n\nEpic: none\nRelease note: None","shortMessageHtmlLink":"kvserver: skip TestBackpressureNotAppliedWhenReducingRangeSize under …"}},{"before":"647934991ab6fe0f0bc2a0eb443c51a64bbb7f9b","after":"a37e053173ebf069b12ef6a2c38a03dd984992e2","ref":"refs/heads/range_size_guardrails","pushedAt":"2023-03-24T15:39:07.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"shralex","name":null,"path":"/shralex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6037719?s=80&v=4"},"commit":{"message":"kv: increase the minimal max_range_size to 64MiB\n\nWe've seen that small range sizes can be detrimental to various\ncomponents. This PR makes it so users can't lower max_range_size\nbelow 64MiB (half of the default min_range_size), instead of 64KiB previously.\n\nRelease Note: Small ranges have been known to cause problems in various\nCRDB subsystems. This PR prevents setting max_range_size below\nCOCKROACH_MIN_RANGE_MAX_BYTES, an environment variable which defaults\nto 64MiB (half of the default minimum range size).\n\nEpic: https://cockroachlabs.atlassian.net/browse/CRDB-24182\nFixes: https://github.com/cockroachdb/cockroach/issues/96549","shortMessageHtmlLink":"kv: increase the minimal max_range_size to 64MiB"}},{"before":null,"after":"5a8a809bbfc7e5441f6e69c8bbe3c2b8269694d4","ref":"refs/heads/flakyTestBehaviorDuringLeaseTransfer","pushedAt":"2023-03-19T23:23:36.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"shralex","name":null,"path":"/shralex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6037719?s=80&v=4"},"commit":{"message":"kvserver: unskip TestBehaviorDuringLeaseTransfer\n\nUnskip this test, its not failing locally. Previous teamcity logs\nare no longer available.\n\nEpic: https://cockroachlabs.atlassian.net/browse/CRDB-21501\nFixes: https://github.com/cockroachdb/cockroach/issues/91948\nRelease note: None","shortMessageHtmlLink":"kvserver: unskip TestBehaviorDuringLeaseTransfer"}},{"before":"6abd7dde2563f6ae200da9c40076775fd820f2c6","after":"647934991ab6fe0f0bc2a0eb443c51a64bbb7f9b","ref":"refs/heads/range_size_guardrails","pushedAt":"2023-03-19T04:23:21.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"shralex","name":null,"path":"/shralex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6037719?s=80&v=4"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEDXtjeQA","startCursor":null,"endCursor":null}},"title":"Activity · shralex/cockroach"}