From 03736592c7d42706cffb6203f0c9dd8d280cd212 Mon Sep 17 00:00:00 2001 From: Terence Hampson Date: Mon, 11 Dec 2023 14:39:02 -0500 Subject: [PATCH] Add new IM Status NO_COMMAND_RESPONSE (#30921) * Add new IM Status NO_COMMAND_RESPONSE * Address PR comments --- docs/ERROR_CODES.md | 1 + src/app/util/af-enums.h | 1 + src/controller/python/chip/interaction_model/__init__.py | 2 ++ src/lib/format/protocol_messages.matter | 2 ++ src/protocols/interaction_model/StatusCodeList.h | 1 + 5 files changed, 7 insertions(+) diff --git a/docs/ERROR_CODES.md b/docs/ERROR_CODES.md index f6ba2767ca40a1..6719af063f41a5 100644 --- a/docs/ERROR_CODES.md +++ b/docs/ERROR_CODES.md @@ -255,5 +255,6 @@ This file was **AUTOMATICALLY** generated by | 1481 | 0x5C9 | `TIMED_REQUEST_MISMATCH` | | 1482 | 0x5CA | `FAILSAFE_REQUIRED` | | 1483 | 0x5CB | `INVALID_IN_STATE` | +| 1484 | 0x5CC | `NO_COMMAND_RESPONSE` | | 1520 | 0x5F0 | `WRITE_IGNORED` | diff --git a/src/app/util/af-enums.h b/src/app/util/af-enums.h index bb694ac31b333b..3bb5745e43cc87 100644 --- a/src/app/util/af-enums.h +++ b/src/app/util/af-enums.h @@ -68,5 +68,6 @@ enum EmberAfStatus : uint8_t EMBER_ZCL_STATUS_TIMED_REQUEST_MISMATCH = 0xC9, EMBER_ZCL_STATUS_FAILSAFE_REQUIRED = 0xCA, EMBER_ZCL_STATUS_INVALID_IN_STATE = 0xCB, + EMBER_ZCL_STATUS_NO_COMMAND_RESPONSE = 0xCC, EMBER_ZCL_STATUS_WRITE_IGNORED = 0xF0, // NOT SPEC COMPLIANT FOR TEST ONLY }; diff --git a/src/controller/python/chip/interaction_model/__init__.py b/src/controller/python/chip/interaction_model/__init__.py index ec6065152d71c0..a2eb5d7ab4ff04 100644 --- a/src/controller/python/chip/interaction_model/__init__.py +++ b/src/controller/python/chip/interaction_model/__init__.py @@ -83,6 +83,8 @@ class Status(enum.IntEnum): PathsExhausted = 0xc8 TimedRequestMismatch = 0xc9 FailsafeRequired = 0xca + InvalidInState = 0xcb + NoCommandResponse = 0xcc class InteractionModelError(ChipStackException): diff --git a/src/lib/format/protocol_messages.matter b/src/lib/format/protocol_messages.matter index 81ca44e701cd55..e13440867b8c41 100644 --- a/src/lib/format/protocol_messages.matter +++ b/src/lib/format/protocol_messages.matter @@ -222,6 +222,8 @@ client cluster IMProtocol = 0xFFFF0001 { kPathsExhausted = 0xc8; kTimedRequestMismatch = 0xc9; kFailsafeRequired = 0xca; + kInvalidInState = 0xcb; + kNoCommandResponse = 0xcc; kWriteIgnored = 0xF0; } diff --git a/src/protocols/interaction_model/StatusCodeList.h b/src/protocols/interaction_model/StatusCodeList.h index 1c37440e5c6eaa..3b79e4a698b7b5 100644 --- a/src/protocols/interaction_model/StatusCodeList.h +++ b/src/protocols/interaction_model/StatusCodeList.h @@ -70,5 +70,6 @@ CHIP_IM_STATUS_CODE(PathsExhausted , PATHS_EXHAUSTED , 0xc8) CHIP_IM_STATUS_CODE(TimedRequestMismatch , TIMED_REQUEST_MISMATCH , 0xc9) CHIP_IM_STATUS_CODE(FailsafeRequired , FAILSAFE_REQUIRED , 0xca) CHIP_IM_STATUS_CODE(InvalidInState , INVALID_IN_STATE , 0xcb) +CHIP_IM_STATUS_CODE(NoCommandResponse , NO_COMMAND_RESPONSE , 0xcc) CHIP_IM_STATUS_CODE(WriteIgnored , WRITE_IGNORED , 0xF0) // non-spec error code and use only internally // clang-format on