From 7c5d5a7b3c8b4eec7f35f663ca017c7867d3ca21 Mon Sep 17 00:00:00 2001 From: shripad621git Date: Fri, 3 May 2024 18:03:47 +0530 Subject: [PATCH] Restlyed --- .../clusters/network-commissioning/network-commissioning.cpp | 5 ----- .../clusters/network-commissioning/network-commissioning.h | 4 ---- src/include/platform/NetworkCommissioning.h | 2 ++ 3 files changed, 2 insertions(+), 9 deletions(-) diff --git a/src/app/clusters/network-commissioning/network-commissioning.cpp b/src/app/clusters/network-commissioning/network-commissioning.cpp index 323fa404301c2e..79d141c5f42f91 100644 --- a/src/app/clusters/network-commissioning/network-commissioning.cpp +++ b/src/app/clusters/network-commissioning/network-commissioning.cpp @@ -57,9 +57,7 @@ using namespace DeviceLayer::NetworkCommissioning; namespace { // For WiFi and Thread scan results, each item will cost ~60 bytes in TLV, thus 15 is a safe upper bound of scan results. -#if CHIP_DEVICE_CONFIG_ENABLE_WIFI_STATION || CHIP_DEVICE_CONFIG_ENABLE_WIFI_AP || CHIP_DEVICE_CONFIG_ENABLE_THREAD constexpr size_t kMaxNetworksInScanResponse = 15; -#endif constexpr uint16_t kCurrentClusterRevision = 2; @@ -623,7 +621,6 @@ void Instance::HandleAddOrUpdateWiFiNetwork(HandlerContext & ctx, const Commands #endif } - #if CHIP_DEVICE_CONFIG_ENABLE_WIFI_PDC void Instance::HandleAddOrUpdateWiFiNetworkWithPDC(HandlerContext & ctx, const Commands::AddOrUpdateWiFiNetwork::DecodableType & req) @@ -754,7 +751,6 @@ void Instance::HandleAddOrUpdateThreadNetwork(HandlerContext & ctx, const Comman #endif } - void Instance::UpdateBreadcrumb(const Optional & breadcrumb) { VerifyOrReturn(breadcrumb.HasValue()); @@ -1184,7 +1180,6 @@ void Instance::OnFinished(Status status, CharSpan debugText, WiFiScanResponseIte #endif } - void Instance::OnPlatformEventHandler(const DeviceLayer::ChipDeviceEvent * event, intptr_t arg) { Instance * this_ = reinterpret_cast(arg); diff --git a/src/app/clusters/network-commissioning/network-commissioning.h b/src/app/clusters/network-commissioning/network-commissioning.h index f0c766b41d3156..cd2d5909c566d1 100644 --- a/src/app/clusters/network-commissioning/network-commissioning.h +++ b/src/app/clusters/network-commissioning/network-commissioning.h @@ -120,13 +120,9 @@ class Instance : public CommandHandlerInterface, // Actual handlers of the commands void HandleScanNetworks(HandlerContext & ctx, const Commands::ScanNetworks::DecodableType & req); - void HandleAddOrUpdateWiFiNetwork(HandlerContext & ctx, const Commands::AddOrUpdateWiFiNetwork::DecodableType & req); - void HandleAddOrUpdateWiFiNetworkWithPDC(HandlerContext & ctx, const Commands::AddOrUpdateWiFiNetwork::DecodableType & req); - void HandleAddOrUpdateThreadNetwork(HandlerContext & ctx, const Commands::AddOrUpdateThreadNetwork::DecodableType & req); - void HandleRemoveNetwork(HandlerContext & ctx, const Commands::RemoveNetwork::DecodableType & req); void HandleConnectNetwork(HandlerContext & ctx, const Commands::ConnectNetwork::DecodableType & req); void HandleReorderNetwork(HandlerContext & ctx, const Commands::ReorderNetwork::DecodableType & req); diff --git a/src/include/platform/NetworkCommissioning.h b/src/include/platform/NetworkCommissioning.h index c02bfe42a5f6be..472ef6d6874d2c 100644 --- a/src/include/platform/NetworkCommissioning.h +++ b/src/include/platform/NetworkCommissioning.h @@ -265,6 +265,7 @@ class WiFiDriver : public Internal::WirelessDriver * message.) */ virtual void OnFinished(Status status, CharSpan debugText, WiFiScanResponseIterator * networks) = 0; + virtual ~ScanCallback() = default; }; @@ -398,6 +399,7 @@ class ThreadDriver : public Internal::WirelessDriver * message.) */ virtual void OnFinished(Status err, CharSpan debugText, ThreadScanResponseIterator * networks) = 0; + virtual ~ScanCallback() = default; };