From bf39f12ce86819e1543dd9aaa36e4e7e4a1b0c78 Mon Sep 17 00:00:00 2001 From: shripad621git Date: Wed, 14 Feb 2024 11:34:15 +0530 Subject: [PATCH] Addressed review comments --- config/esp32/components/chip/Kconfig | 8 ++++++-- src/tracing/esp32_trace/esp32_tracing.cpp | 2 +- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/config/esp32/components/chip/Kconfig b/config/esp32/components/chip/Kconfig index ba23c89b0cc3dc..b38fc5e18c3d10 100644 --- a/config/esp32/components/chip/Kconfig +++ b/config/esp32/components/chip/Kconfig @@ -913,11 +913,15 @@ menu "CHIP Device Layer" help This option enables the system statistics to be sent to the insights cloud. - config INSIGHTS_TRACE_PERMIT_LIST_SIZE - int "Config option to set permitlist size" + config MAX_PERMIT_LIST_SIZE + int "Set permit list size for Insights traces" range 5 30 depends on ESP_INSIGHTS_ENABLED default 20 + help + Maximum number of group entries that can be included in the permit list for reporting + the traces to insights. + endmenu diff --git a/src/tracing/esp32_trace/esp32_tracing.cpp b/src/tracing/esp32_trace/esp32_tracing.cpp index c3efa3a127065c..1d5847df9a2c0d 100644 --- a/src/tracing/esp32_trace/esp32_tracing.cpp +++ b/src/tracing/esp32_trace/esp32_tracing.cpp @@ -30,7 +30,7 @@ namespace Tracing { namespace Insights { namespace { -constexpr size_t kPermitListMaxSize = CONFIG_INSIGHTS_TRACE_PERMIT_LIST_SIZE; +constexpr size_t kPermitListMaxSize = CONFIG_MAX_PERMIT_LIST_SIZE; using HashValue = uint32_t; // Implements a murmurhash with 0 seed.