Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caches don't necessarily work #29

Open
kawaii opened this issue Mar 5, 2019 · 2 comments
Open

Caches don't necessarily work #29

kawaii opened this issue Mar 5, 2019 · 2 comments
Labels
enhancement New feature or request
Milestone
1.0

Comments

@kawaii
Copy link
Member

kawaii commented Mar 5, 2019

the API object caches guilds and channels but these don't necessarily work correctly
@kawaii kawaii added the enhancement New feature or request label Mar 5, 2019
@kawaii kawaii added this to the 1.0 milestone Mar 5, 2019
@kawaii kawaii added bug Something isn't working and removed enhancement New feature or request labels Mar 5, 2019
@Altreus
Copy link
Member

Altreus commented Mar 11, 2020

We can use https://github.com/lizmat/ObjectCache on the ButReals.

Then we can use the new EVICT behaviour to force a re-fetch if necessary.

This will then just straight up cache everything. Nice.

@Altreus Altreus added enhancement New feature or request and removed bug Something isn't working labels Mar 11, 2020
@Altreus
Copy link
Member

Altreus commented Mar 11, 2020

Put this back as enhancement because also I think it works OK now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@Altreus @kawaii