Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO #1

Open
17 of 34 tasks
konradkonrad opened this issue Mar 12, 2024 · 2 comments
Open
17 of 34 tasks

TODO #1

konradkonrad opened this issue Mar 12, 2024 · 2 comments

Comments

@konradkonrad
Copy link
Contributor

konradkonrad commented Mar 12, 2024

Functionality

  • test Deposit

Usability

  • Field validation

    • Receiver
    • Value
    • Data (must have: validation of well-formed data. nice to have: display decoded data next to input field)
    • ABI: address
    • ABI: ints
    • ABI: hex
  • Disable Deposit button while waiting for tx

  • + add status message during deposit

Buggy

  • race condition: blocklistener sees block but signer.provider can not fetch it in decodeShopReceipt
  • error handling when sending value to non-payable
  • value validation for empty field
  • MM change account after connect
  • shutter-provider network change on deposit:
    Error: network changed: 42055420 => 11155111 (event="changed", code=NETWORK_ERROR, version=6.11.1)

Cosmetics

  • Center app view
  • background over whole viewport
  • Welcome header layout / items flow

Deployment

  • Remove StrictMode
  • don't run dev mode

Done

  • Abi Name / Selector

  • "You need to sign the tx before the timer runs out."

  • L2 Balance 0.74387934 Add more.

  • Set value 0 when clicking Generate Calldata on non-payable ABI method (regression)

  • Camera already in TX form

  • Trying to switch to SHOP (no effect on first page load):
    MetaMask - RPC Error: Unrecognized chain ID "0x281b6fc". Try adding the chain using wallet_addEthereumChain first

  • Status messges in a box

  • Status order (reverse)

  • TXform value "in wei"

  • Use ABI only when contractData for Receiver

  • Logo margin.

  • Faucet links in Deposit page

  • Welcome to shutterized optimism on Sepolia. Send shutter encrypted transactions with this dApp.

  • "Shutter is paused. Contact https://t.me/shutter_network/1"

@fredo
Copy link
Contributor

fredo commented Mar 19, 2024

  •  Be able to switch account

@fredo
Copy link
Contributor

fredo commented Mar 19, 2024

shutter-provider network change on deposit:
Error: network changed: 42055420 => 11155111 (event="changed", code=NETWORK_ERROR, version=6.11.1)

I Think this error happens if you are already switched to sepolia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants