Fix #697: a crash in the Watermark plugin if screenshot name includes spaces #698
Conversation
|
Looks like I introduced the issue in #380... |
| @@ -362,7 +362,7 @@ sub apply_effect { | |||
|
|
|||
| my $command2 = "composite " . $tmpfilename . | |||
| " -gravity " . $gravity_combo->get_active_text . | |||
| " " . $filename . " " . $tmpfilename2; | |||
There was a problem hiding this comment.
better not to use backtick at all, but to use some other ways to run subprocess. Or at least escape filesnames and such.
There was a problem hiding this comment.
Well, with a system call it resulted in an error which I couldn't understand (here is my question about it: https://stackoverflow.com/questions/68628648/the-and-comma-operators-in-a-perl-system-call).
What else would you propose instead of backticks?
There was a problem hiding this comment.
If I just revert your previous change, the system call works fine for me. What was the issue?
There was a problem hiding this comment.
It crashed when clicking on "refresh" or "apply" three years ago, see #379.
I can actually still reproduce it. The plugin window just disappears and the screenshot stays untouched.
There was a problem hiding this comment.
can you show logs of this?
it works perfectly for me, if I revert your old commit
There was a problem hiding this comment.
Still crashes as in #379, unfortunately. Note for later, perl-ipc-run3 as new dependency required if we want to pursue this variant.
There was a problem hiding this comment.
But is the log any better there why it crashes?
There was a problem hiding this comment.
Nope, it's still the same...
There was a problem hiding this comment.
well, I don't know how to debug this further for you.
you can merge this PR, of course, but don't be surprised when the next issue opened will be "crash if the name includes the quote character" or something like that
can you try to write a small script (without any shutter or even gtk) which just runs these 2 commands via backticks / via run3, and see what it says?
No description provided.