Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It DELETED all my packages!!! #104

Open
xeroxstar opened this issue Oct 19, 2019 · 5 comments
Open

It DELETED all my packages!!! #104

xeroxstar opened this issue Oct 19, 2019 · 5 comments

Comments

@xeroxstar
Copy link

xeroxstar commented Oct 19, 2019

I installed this module and run in my project as it shown in the tutorial and it deleted all my modules, are you serious? All my modules F... GONE!!!!!!!

× html5sortable removed
× parse-function removed
× eslint removed
× vue2-brace-editor removed
× esprima removed
× decache removed
× auto-install removed
× register-service-worker removed
× splitpanes removed
× vuex removed
- Uninstalling @fortawesome/fontawesome-free

and none of them could be installed back by giving me this nonsense:

- Installing chokidar
npm ERR! path  ... \node_modules\normalize-path
npm ERR! code ENOENT
npm ERR! errno -4058
npm ERR! syscall rename
npm ERR! enoent ENOENT: no such file or directory, rename

holly crap, it should say auto-uninstall and not auto-install !!!!

@xeroxstar xeroxstar changed the title Uninstalling?? It DELETED all my packages!!! Oct 19, 2019
@OmgImAlexis
Copy link

You had your package.json checked into git, no?

@ceafive
Copy link
Collaborator

ceafive commented May 12, 2020

Sorry @xeroxstar this happened because the module searched your files and found no explicit 'import' of these modules hence it removed them. I have pushed a commit to make 'uninstall' false on default.

@siddharthkp
Copy link
Owner

@ceafive just a pointer, keep backward compatibility in mind

@ceafive
Copy link
Collaborator

ceafive commented May 13, 2020

@siddharthkp yeah got it. This is barely a breaking change I suppose but this solves a critical problem many people might have

@siddharthkp
Copy link
Owner

uninstall is a feature not a bug :)

however, it's supposed to only removed unused packages, not all of them like the issue creator posted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants