-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better perf with differential parsing #22
Comments
Shall work on this? |
Sure! Just one thing to remember, when a file is deleted, you will have to go through all the files as that file is no longer available. |
OK thanks will update once done |
If you get stuck anywhere because of my code, don't hesitate to ask |
updated the code like below but the problem now, because in change event we are getting module from one page, all other page modules consider as unused modules by following line of code
any suggestion how can handle this? |
Implementing path specific logic for |
check is the below steps are OK.
|
Nothing wrong with your approach, but personally I'm not a fan of storing these details in a local variable unless there is no other approach. More logic, more bugs? Would prefer a pure function instead. In the current implementation, I just rerun the same function every time. But, parsing all the files is an expensive action. Relevant use cases in the current implementation,
I think that the first point is the most common use case and will benefit the most. That being said, I don't want to discourage your implementation, if you can make the local store clean + testable, the performance benefits will be totally worth it. |
ok will do my best :) |
hi, |
Seems about right |
Thanks for your time. I ll continue same way |
hi |
Reduce the number of files parsed in each cycle.
Read all the files only delete event.
Chain events?
The text was updated successfully, but these errors were encountered: