Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File size equals maxSize should still be a pass, right? #389

Open
rwaldron opened this issue Jun 11, 2024 · 0 comments
Open

File size equals maxSize should still be a pass, right? #389

rwaldron opened this issue Jun 11, 2024 · 0 comments

Comments

@rwaldron
Copy link

Do you want to request a feature or report a bug?

bug

What is the current behavior?

FAIL  ./file.js: 1.5KB > maxSize 1.5KB

If the current behavior is a bug, please provide the steps to reproduce.

Have a file with a size that is exactly equal to the "maxSize", it will fail.

What is the expected behavior?

Assuming "maxSize" is an abbreviation of "maximum size" and that we're going by the universal definition of the word "maximum" in its noun and adverb forms, then "maxSize" should be inclusive, ie. "The maximum size allowed for this file is 1.5kB"... which means a file that's 1.5kB should pass.

If this is a feature request, what is motivation or use case for changing the behavior?

Correctness.

Please mention other relevant information.

  • bundlesize version is 0.18.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant