Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Stack specificity issues #40

Closed
siddharthkp opened this issue Apr 16, 2020 · 2 comments · Fixed by #84
Closed

Fix Stack specificity issues #40

siddharthkp opened this issue Apr 16, 2020 · 2 comments · Fixed by #84
Assignees
@Sagarpreet
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
1.0.0

Comments

@siddharthkp
Copy link
Owner

siddharthkp commented Apr 16, 2020 •
edited
Loading

When you put elements in a Stack with gap, the gap overrides the margins on individual elements because it has higher specificity. (example in codesandbox link below)

But, if we use the lobotomized owl selector, we can solve this!

I had completely forgot about the lobotomized owl, that article ⬆️ is from 2013! and was reminded of it from a tweet by @adamwathan! cheers to him!

Repro and suggested fix (Stack 2): https://codesandbox.io/s/infallible-proskuriakova-5zwzg
@siddharthkp siddharthkp added bug Something isn't working good first issue Good for newcomers labels Apr 16, 2020
@siddharthkp siddharthkp added this to the 1.0.0 milestone Apr 16, 2020
@Sagarpreet
Copy link

Hey can i take this up?

@siddharthkp
Copy link
Owner Author

@Sagarpreet Sure, go for it

@Sagarpreet Sagarpreet mentioned this issue Apr 26, 2020
Closed
@siddharthkp siddharthkp mentioned this issue May 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sagarpreet Sagarpreet

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Fix specificity issues siddharthkp/react-ui
Fixes Stack specificity issues Sagarpreet/react-ui
2 participants
@siddharthkp @Sagarpreet