프로젝트 전체 조회 시 기술 스택 및 제목과 멤버로 검색 기능 #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto feat/#173-read-projects-with-search
📝 Jacoco Test Coverage
|
This was
linked to
issues
Mar 18, 2024
Closed
uijin-j
reviewed
Mar 18, 2024
| @@ -111,23 +141,48 @@ private Page<ProjectListResponse> findPageByCondition(EntityPathBase<?> from, | |||
|
|
|||
| private Long getCount(EntityPathBase<?> from, BooleanExpression condition, QProject join) { | |||
| return queryFactory | |||
| .select(project.count()) | |||
| .select(project.countDistinct()) | |||
There was a problem hiding this comment.
count()와 countDistinct() 차이를 알 수 있을까용??
중복 필터링같긴 한데, 혹시 중복된 프로젝트가 조회되는 경우도 있을까요?
There was a problem hiding this comment.
제가 검색 기능을 구현하면서, getCount()를 잠시 사용한 적이 있는데 전체 프로젝트 개수를 반환할 때 중복되는 경우가 있기에 distinct를 추가했습니다!
Comment on lines
+239
to
+246
| // 프로젝트 ID 서브쿼리를 생성하여 스킬을 모두 포함하는 프로젝트를 찾기 | ||
| JPAQuery<Long> projectHasSkillsSubQuery = queryFactory | ||
| .select(projectSkill.project.id) | ||
| .from(projectSkill) | ||
| .join(projectSkill.skill) | ||
| .where(projectSkill.skill.name.in(skillNames)) | ||
| .groupBy(projectSkill.project.id) | ||
| .having(projectSkill.project.id.count().eq(Expressions.constant(skillNames.size()))); |
There was a problem hiding this comment.
좋아요랑 비슷한 형식같아 보이네용!
혹시 좋아요는 좋아요 서비스에서 구현했지만, 스킬은 프로젝트 레포지토리에서 구현한 이유가 따로 있을까융?
There was a problem hiding this comment.
저도 ProjectSkill에 구현할까 고민했었지만, 우선 기능 개발이 중요하기에 project에 우선적으로 구현했습니다! 확실히 분리해보이는 것이 좋겠네요! 리팩토링하면서 분리하도록 하겠습니다! 좋은 의견 감사합니다 🙇
uijin-j
approved these changes
Mar 18, 2024
Sehee-Lee-01
approved these changes
Mar 18, 2024
src/main/java/sixgaezzang/sidepeek/common/doc/description/ProjectDescription.java
Show resolved
Hide resolved
src/main/java/sixgaezzang/sidepeek/projects/controller/ProjectController.java
Show resolved
Hide resolved
src/main/java/sixgaezzang/sidepeek/projects/dto/request/FindProjectRequest.java
Show resolved
Hide resolved
src/main/java/sixgaezzang/sidepeek/projects/repository/project/ProjectRepositoryCustomImpl.java
Outdated
Show resolved
Hide resolved
📝 Jacoco Test Coverage
|
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 관련 이슈
Resolves #107
Resolves #158
Fix #173
✅ 구현 내용
💬 코멘트
프로젝트 메인과 검색 결과 페이지에서 기술 스택 별로 검색하는 기능 구현 완료했습니다.
우선 dev에 merge 시키기 위한 목적으로 테스트 코드는 아직 작성하지 않았습니다. 테스트 코드는 천천히 작성해 보려고 합니다!