fix: Don't fetch session during nitro prerender #496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @tesla3327 Thank you for your contribution! You said that you tested and I assume found the issue in 0.5.0. Is this also present in 0.6.0? I would assume so, as your contribution is for v0.6! Please also have a look at the linting issues the CI caught and then we can move on to a proper review! |
|
I can confirm that prerender does throw an error in the latest version as well. Other than linting, anything else holding this PR back? |
|
@zoey-kaiser I'm seeing this as well. Can we accept this? |
|
@zoey-kaiser Done. Have a look at #521 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During prerendering
getSessionis currently always called, even on non-protected pages, giving this error:ERROR [nuxt] [request error] [unhandled] [500] fetch failed (http://localhost:3000/api/auth/session?callbackUrl=http://localhost/)This change just checks if we're prerendering or not, using the
x-nitro-prerenderheader set by Nitro during prerendering.I found this issue in
0.5.0but I'm not sure if you're doing patch releases on this or not.