Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sidekiq::Orm::ManagerWorker #3

Open
yelled3 opened this issue May 22, 2014 · 0 comments
Open

Add Sidekiq::Orm::ManagerWorker #3

yelled3 opened this issue May 22, 2014 · 0 comments
Assignees

Comments

@yelled3
Copy link

yelled3 commented May 22, 2014

should be logic only and delegate the ORM interaction to ORM specific module.
e.g

# activerecord module
def select_models
     models = models_query.select(selected_attributes)
end
# and
def find_in_batches
     models.find_in_batches(batch_size: batch_size) do |models_batch|
end

sidekiq-orm/sidekiq-activerecord#2 (comment)

@seuros I'm not sure if find_in_batches is available in other ORMs.
need to think about it.

@seuros seuros self-assigned this May 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants