Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unique_rows does not support tolerance #32

Open
VolkerH opened this issue Aug 12, 2022 · 0 comments
Open

unique_rows does not support tolerance #32

VolkerH opened this issue Aug 12, 2022 · 0 comments

Comments

@VolkerH
Copy link

VolkerH commented Aug 12, 2022

While the tests for unique_rows also test float arrays, unique_rows does not support a tol argument such as unique.
I tried to fix this by replacing the call to np.unique in https://github.com/nschloe/npx/blob/main/src/npx/_unique.py#L53 to a call to your unique that supports a tol argument but that simple fix did not do the trick unfortunately (led to some ufunc dtype incompatibility exception)
It would be nice if unique_rows also supported a tol argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant