-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functions to quickly generate sample pose objects #12
Comments
It still gives a feel (atleast to me) as if this Something like this might be a bit better: random_pose_object = pose_format.Pose.random(num_frames=10, num_keypoints=137, num_coordinates=3) |
Thanks for your comments @GokulNC ! I think that we can provide something like this, yes. Some explanations for the code I first proposed:
|
Interesting. But why is it mandatory to have headers for model_names like openpose or holistic? What if I want to store a manually annotated keypoints dataset? (like coco) Isn't better to allow it to be generic? Especially since there are many more pose detectors out there and covering all cases might be very difficult / unnecessary. Regarding |
(we need to wait for @AmitMY for definitive information, since he is the main developer of this library :) ) My personal opinion is that headers lead to more data integrity and lower the chances of introducing bugs inadvertently. Regarding the spec: the way a pose file is stored on disk is indeed generic and independent of numpy/tf/torch. But once it is loaded into memory, it holds the data as either numpy, tf or torch. If you'd like to propose a different solution we'd love to hear about it, and are open to contributions as well. |
@GokulNC The format is generic. You can create a COCO header, or a Kinect header, or whatever you want, it is quite simple I think. What @bricksdont is suggesting here iirc, is a for-testing-only utility function to create an The body is also generic - but to have it in memory you have to make a decision how to load it - with numpy? torch? tensorflow? a custom implementation? Would you like to maybe have a call discussing this? |
OK, this makes sense. Thanks! (Sorry for diverging from what this issue was originally about) |
Based on this discussion:
AI4Bharat/OpenHands#29 (comment)
I think there is a need for code to quickly generate pose objects, with the Posebody type as a variable argument. I can take the code for this from unit tests, e.g. https://github.com/AmitMY/pose-format/blob/master/pose_format/pose_test.py#L159
This is what I had in mind:
The text was updated successfully, but these errors were encountered: