Question: What branch is stable?

[kvishnivetsky]

Hi!

What branch contains stable code?
What branch contains development code?

[dragos-oancea]

master branch is the branch you want.

[baloian]

I am getting the following error on master branch. @kvishnivetsky did you get the same?

  CCLD     stirshaken
/usr/bin/ld: util/src/stirshaken-stir_shaken_tool.o:/home/artiom/libstirshaken/util/include/stir_shaken_tool.h:231: multiple definition of `options'; util/src/stirshaken-stir_shaken_tool_command.o:/home/artiom/libstirshaken/util/include/stir_shaken_tool.h:231: first defined here
/usr/bin/ld: util/src/stirshaken-stir_shaken_tool.o:/home/artiom/libstirshaken/util/include/stir_shaken_tool.h:197: multiple definition of `sp'; util/src/stirshaken-stir_shaken_tool_command.o:/home/artiom/libstirshaken/util/include/stir_shaken_tool.h:197: first defined here
/usr/bin/ld: util/src/stirshaken-stir_shaken_tool.o:/home/artiom/libstirshaken/util/include/stir_shaken_tool.h:185: multiple definition of `pa'; util/src/stirshaken-stir_shaken_tool_command.o:/home/artiom/libstirshaken/util/include/stir_shaken_tool.h:185: first defined here
/usr/bin/ld: util/src/stirshaken-stir_shaken_tool.o:/home/artiom/libstirshaken/util/include/stir_shaken_tool.h:174: multiple definition of `ca'; util/src/stirshaken-stir_shaken_tool_command.o:/home/artiom/libstirshaken/util/include/stir_shaken_tool.h:174: first defined here
collect2: error: ld returned 1 exit status
make: *** [Makefile:1260: stirshaken] Error 1

[slackr31337]

@baloian I'm getting that same output when attempting to build on Debian 11.

[baloian]

@slackr31337 I solved. The problem is that libstirshaken/util/include/stir_shaken_tool.h file is included in two different .c files: stir_shaken_tool.c and stir_shaken_tool_command.c. You need do copy-paste code from stir_shaken_tool_command.c to stir_shaken_tool.c and comment source code inside of stir_shaken_tool_command.c.

This is not the best solution but it works.

[piotrgregor]

SignalWire doesn't seem to maintain this library. I do maintain my fork here. It has this issue fixed and this PR merged. Enjoy!

[crienzo]

This is untrue. All of our open source projects are community supported. Please submit your PR here for review.

[crienzo]

@piotrgregor this will be your first and only warning to participate constructively and positively with signalwire's and freeswitch's open source projects.

[andywolk]

@baloian The error you mentioned is fixed in master. Answering your question: you should use master as it's our default branch. Open another issue if there is any problem still. I'm closing this for now.